784041 - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_bug413915.js | Exception thrown at chrome://mochitests/content/browser/suite/browser/test/browser_bug413915.js:7 - TypeError: secman.getCodebasePrincipal is not a functi

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, defect, P2)

Description

[Philip Chee]

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_bug413915.js | Exception thrown at chrome://mochitests/content/browser/suite/browser/test/browser_bug413915.js:7 - TypeError: secman.getCodebasePrincipal is not a function

q.v. Firefox Bug 774585: Rename getCodebasePrincipal to getSimpleCodebasePrincipal since the behavior has semantically changed.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Fix test and FeedWriter.js

$ TEST_PATH=suite/browser/test/browser_bug413915.js pymake -C ../objdir-sm/ mochitest-browser-chrome

Before:
INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 0
        Failed: 1
        Todo: 0

After:
INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 16
        Failed: 0
        Todo: 0

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 653396 [details] [diff] [review]
Patch v1.0 Fix test and FeedWriter.js

This ports
http://hg.mozilla.org/mozilla-central/rev/2328647c5d6d
from bug 774585.

Ftr, you attached FeedWriter.js part to bug 776577 (where I expected all this to be fixed) too :-|

r+ (as copying FF code).
NB: I assume you need an additional review for FeedWriter.js.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Ftr, you attached FeedWriter.js part to bug 776577 (where I expected all
> this to be fixed) too :-|

s/you/Neil/ ;->

Comment 4

[Philip Chee]

>> Ftr, you attached FeedWriter.js part to bug 776577 (where I expected all
>> this to be fixed) too :-|
Oops. I'll file a new patch without the changes to FeedWriter.js

Comment 5

[Philip Chee]

Attachment: Patch v1.1 fix test only r=sgautherie.

>> Ftr, you attached FeedWriter.js part to bug 776577 (where I expected all
>> this to be fixed) too :-|
>Oops. I'll file a new patch without the changes to FeedWriter.js

Comment 6

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/ac438606c3a6

Comment 7

[[e-mail]]

(In reply to Philip Chee from comment #4)
> > Ftr, you attached FeedWriter.js part to bug 776577 (where I expected all
> > this to be fixed) too :-|
> Oops. I'll file a new patch without the changes to FeedWriter.js
Bah, I didn't realise you did this and went to great steps to check in bug 776577 without the FeedWriter.js change only to discover that you hadn't actually patched it after all :-P