784055 - Remove code dealing with offsetWidth in Readability.js

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Lucas Rocha (:lucasr)]

We don't run readability.js on top of a live DOM tree anymore. This means all the runtime dimension bits are undefined while running the readability check in the worker thread.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Remove all code dealing with offsetWidth in Readability.js

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 653405 [details] [diff] [review]
Remove all code dealing with offsetWidth in Readability.js

I assume that since we don't support _fixImageFloats(), this could cause floated images to look bad in some cases. If we run into this, maybe we could fake support for offsetWidth if we pass in the viewport width to the worker/DOMParser, then attach the width to the document.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Comment on attachment 653405 [details] [diff] [review]
> Remove all code dealing with offsetWidth in Readability.js
> 
> I assume that since we don't support _fixImageFloats(), this could cause
> floated images to look bad in some cases. If we run into this, maybe we
> could fake support for offsetWidth if we pass in the viewport width to the
> worker/DOMParser, then attach the width to the document.

I've added all the intelligence to handle block images and floats to the reader itself given our use of web workers to parse pages.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/359d21e0b88a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/359d21e0b88a

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 653405 [details] [diff] [review]
Remove all code dealing with offsetWidth in Readability.js

[Approval Request Comment]
User impact if declined: Remove overhead from readability check. 
Testing completed (on m-c, etc.): Landed on m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Low, this patch is removing no-op code from readability.js.
String or UUID changes made by this patch: None.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed to mozilla-aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/d0e7a18fd101

Comment 8

[Cristian Nicolae (:xti)]

The code was cleaned up on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4