784060 - Port Bug 768568 to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect, P2)

Description

[Philip Chee]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1345402578.1345407329.8417.gz

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the front notifications listener - Got onSecurityChange, expected onStateChange
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the all notifications listener - Got onSecurityChange, expected onStateChange
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got an expected notification for the front notifications listener
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the front notifications listener - Got onStateChange, expected undefined
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got an expected notification for the all notifications listener
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the all notifications listener - Got onStateChange, expected undefined
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Saw the expected number of notifications - Got 5, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Saw the expected number of frontnotifications - Got 5, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the all notifications listener - Got onSecurityChange, expected onStateChange
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got an expected notification for the all notifications listener
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Got a notification for the all notifications listener - Got onStateChange, expected undefined
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | Saw the expected number of notifications - Got 5, expected 4

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Do it.

Before:
INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 111
        Failed: 16
        Todo: 0


After:
finished in 538ms
TEST-INFO | checking window state
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | leaked until shutdown [nsGlobalWindow #25 https://example.com/browser/suite/browser/test/alltabslistener.html]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | leaked until shutdown [nsGlobalWindow #24 http://example.org/browser/suite/browser/test/alltabslistener.html]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | leaked until shutdown [nsGlobalWindow #23 https://example.com/browser/suite/browser/test/alltabslistener.html]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_alltabslistener.js | leaked until shutdown [nsGlobalWindow #22 http://example.org/browser/suite/browser/test/alltabslistener.html]

INFO TEST-START | Shutdown
Browser Chrome Test Summary
        Passed: 123
        Failed: 4
        Todo: 0

Comment 2

[Serge Gautherie (:sgautherie)]

Ftr, this patch undoes bug 752211.

I can't say more until I can access bug 768568 :-/
"You are not authorized to access bug #768568."

Comment 3

[[e-mail]]

Comment on attachment 653409 [details] [diff] [review]
Patch v1.0 Do it.

Bah, so Gecko has to work around bugs in Firefox front end code?

Comment 4

[[e-mail]]

(In reply to Serge Gautherie from comment #2)
> Ftr, this patch undoes bug 752211.
That's not surprising, since 768568 undoes parts of 745254.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 653409 [details] [diff] [review]
Patch v1.0 Do it.

f+, as this ports
http://hg.mozilla.org/mozilla-central/rev/36bf4862be19
"Bug 768568, r=kaie"

(Though I still can't access that bug.)

***

It seems branches need this too:
http://hg.mozilla.org/releases/mozilla-aurora/rev/49848d305daa
http://hg.mozilla.org/releases/mozilla-aurora/rev/6d0ad34230a0
+
http://hg.mozilla.org/releases/mozilla-beta/rev/f27018523082
http://hg.mozilla.org/releases/mozilla-beta/rev/972dd5cab80c

Comment 6

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/14441f0e2747

Leaving open for comm-aurora and comm-beta.

Comment 7

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-beta/rev/97c9fb2486da

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1345544030.1345547174.646.gz
Linux comm-central-trunk debug test mochitest-other on 2012/08/21 03:13:50

V.Fixed

Comment 9

[Philip Chee]

http://hg.mozilla.org/releases/comm-aurora/rev/990b3cabed5d