784073 - Metro Firefox brings up new tab page when focusing location bar with autocomplete

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Brian R. Bondy [:bbondy]]

Steps to reproduce:
1. Open metro Firefox.
2. Start typing something in, autocomplete pops up
3. Press Ctrl+L, new tab page pops up

Expected results:
autcomplete should remain

Actual results:
New tab page pops up

Comment 1

[Matt Brubeck (:mbrubeck)]

Stealing this.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This issue is caused by this code, added by bug 747786.  Blurring the urlbar causes it to exit "filtering" mode.  It's not clear what bug this is supposed to work around or how to reproduce it.  Are there details anywhere?

If we can't remove this blur, then we'll need to add more code to work around it and restore the filtering...

Comment 3

[Jim Mathies [:jimm]]

I think that's been in there since the initial copy from mobile. I tried searching back through blame but couldn't find anything. I'd say if it's breaking something, take it out and see what happens.

Comment 4

[Matt Brubeck (:mbrubeck)]

This code was never in mobile.  It was added to browser/metro by this changeset:
https://hg.mozilla.org/projects/elm/rev/ea88e925d52f#l12.118

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 660618 [details] [diff] [review]
patch

I commented this out and did a little testing, I see no side effects.

Comment 6

[Jonathan Wilde [:jwilde]]

Comment on attachment 660618 [details] [diff] [review]
patch

Sorry for being slow to notice this request.

+1 for removing the `mode` variable.

As for the .blurFocusedElement() bit, that was part of me trying to clobber an issue where the URL bar would visually be selected, but the keyboard wouldn't show up and allow you to type text in (due to a11y binding issues).  That was related to some buggy initial changes that I did to the autocomplete XBL binding several months ago, which because the autocomplete XBL is an nsIAccessibleProvider, broke some of the relevant a11y bindings.

Some of my later refactoring work on autocomplete fixed all of those issues as far as I'm aware, so +1 removing the .blurFocusedElement() call, too.

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 660618 [details] [diff] [review]
patch

Based on jwilde's comment, I think we should land this.

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 660618 [details] [diff] [review]
patch

I've been running with this in my queue - no issues. r+

Comment 9

[Matt Brubeck (:mbrubeck)]

Landed on elm a while ago:
http://hg.mozilla.org/projects/elm/rev/72cf22864861

Comment 10

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.