Speedometer needle on speed page is crazy

VERIFIED FIXED in Future

Status

www.mozilla.org
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: matej, Assigned: sgarrity)

Tracking

unspecified
Future

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sp-2012-08-28] u=user c=general p=1, URL)

(Reporter)

Description

6 years ago
Tried this on both Nightly and Aurora: The needle moves slowly up to the right, then starts spinning wildly. Seems to work fine on Final Release.

Updated

6 years ago
Target Milestone: --- → Future

Comment 1

6 years ago
+1 - does confirm wildly. That needle is crazy. 

Would be great to get this fixed as we use this landing page on a ongoing basis, as part of our arsenal of landing pages.
I think Mike worked on this initially. Mike can you take a look?
(Assignee)

Comment 3

6 years ago
Yup, we'll sort this out. Aurora/Nightly are obviously just TOO FAST.

Updated

6 years ago
Assignee: nobody → steven
Whiteboard: [sp-2012-08-28] u=user c=general p=1
It might be a bug in Firefox or in jQuery. If that's the case, we should report it to the appropriate project.
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
(Assignee)

Comment 5

6 years ago
We've got a fix locally - refining/testing now.
(Reporter)

Comment 7

6 years ago
(In reply to Steven Garrity from comment #5)
> We've got a fix locally - refining/testing now.

Will that automatically fix the new Performance page that uses the same needle as well?
(Assignee)

Comment 8

6 years ago
(In reply to Matej Novak [:matej] from comment #7)
> (In reply to Steven Garrity from comment #5)
> > We've got a fix locally - refining/testing now.
> 
> Will that automatically fix the new Performance page that uses the same
> needle as well?

Yes, once this fix is in production, the code is shared for both /speed/ and /memory/ pages, so both will be fixed.
So before fixing this ourselves, I've done a bit of regression finding. This broke in this range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d9d61d199b11&tochange=a31fc9052840
This needle is present on those pages:

- http://www.mozilla.org/en-US/firefox/speed/
- http://www.mozilla.org/en-US/firefox/happy/
- http://www.mozilla.org/en-US/firefox/toolkit/download-to-your-devices/


The problem here is that Firefox 16 unprefixed CSS transforms and the lib we're using doesn't like that.

Comment 12

6 years ago
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9baeda55260279ef18c8308fa65adc32a9c5795e
Fix crazy needle.

fix bug 784095

- Drop the jQuery CSS transform and rotation library in favour of a simpler hack.
- Update the speed and device pages to use the new method.
- Externalize JS for speed, device and happy pages.

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
This is now pushed to production.
Keywords: qawanted
OS: Mac OS X → All
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.