784095 - Speedometer needle on speed page is crazy

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Matej Novak [:matej]]

Tried this on both Nightly and Aurora: The needle moves slowly up to the right, then starts spinning wildly. Seems to work fine on Final Release.

Comment 1

[Laura Forrest]

+1 - does confirm wildly. That needle is crazy. 

Would be great to get this fixed as we use this landing page on a ongoing basis, as part of our arsenal of landing pages.

Comment 2

[Anthony Ricaud (:rik)]

I think Mike worked on this initially. Mike can you take a look?

Comment 3

[Steven Garrity [:sgarrity]]

Yup, we'll sort this out. Aurora/Nightly are obviously just TOO FAST.

Comment 4

[Anthony Ricaud (:rik)]

It might be a bug in Firefox or in jQuery. If that's the case, we should report it to the appropriate project.

Comment 5

[Steven Garrity [:sgarrity]]

We've got a fix locally - refining/testing now.

Comment 6

[Michael Gauthier [:gauthierm]]

https://github.com/mozilla/bedrock/pull/321

Comment 7

[Matej Novak [:matej]]

(In reply to Steven Garrity from comment #5)
> We've got a fix locally - refining/testing now.

Will that automatically fix the new Performance page that uses the same needle as well?

Comment 8

[Steven Garrity [:sgarrity]]

(In reply to Matej Novak [:matej] from comment #7)
> (In reply to Steven Garrity from comment #5)
> > We've got a fix locally - refining/testing now.
> 
> Will that automatically fix the new Performance page that uses the same
> needle as well?

Yes, once this fix is in production, the code is shared for both /speed/ and /memory/ pages, so both will be fixed.

Comment 9

[Anthony Ricaud (:rik)]

So before fixing this ourselves, I've done a bit of regression finding. This broke in this range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d9d61d199b11&tochange=a31fc9052840

Comment 10

[Anthony Ricaud (:rik)]

This needle is present on those pages:

- http://www.mozilla.org/en-US/firefox/speed/
- http://www.mozilla.org/en-US/firefox/happy/
- http://www.mozilla.org/en-US/firefox/toolkit/download-to-your-devices/


The problem here is that Firefox 16 unprefixed CSS transforms and the lib we're using doesn't like that.

Comment 11

[Michael Gauthier [:gauthierm]]

https://github.com/mozilla/bedrock/pull/325

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9baeda55260279ef18c8308fa65adc32a9c5795e
Fix crazy needle.

fix bug 784095

- Drop the jQuery CSS transform and rotation library in favour of a simpler hack.
- Update the speed and device pages to use the new method.
- Externalize JS for speed, device and happy pages.

Comment 13

[Anthony Ricaud (:rik)]

This is now pushed to production.

Comment 14

[raymond [:retornam] (inactive)]

verified fixed 


- http://www.mozilla.org/en-US/firefox/speed/
- http://www.mozilla.org/en-US/firefox/happy/
- http://www.mozilla.org/en-US/firefox/toolkit/download-to-your-devices/