Closed Bug 784126 Opened 8 years ago Closed 8 years ago

Fix JSDOMParser textContent setter

Categories

(Firefox for Android :: Reader View, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 17
Tracking Status
firefox16 --- fixed

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

The textContent setter is incorrectly called "textContext". Also, we should clear the parentNode for its children when we replace the childNodes.
Attachment #653483 - Flags: review?(lucasr.at.mozilla)
Blocks: 779796
Comment on attachment 653483 [details] [diff] [review]
Fix JSDOMParser textContent setter

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 779796
User impact if declined: some parsed articles may show up incorrectly
Testing completed (on m-c, etc.): none yet
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none
Attachment #653483 - Flags: approval-mozilla-aurora?
Attachment #653483 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/fcb1cb11935f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Attachment #653483 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.