784186 - Robocop: several tests sometimes fail loading second page

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

testHistoryTab usually fails when I run it on the Galaxy Nexus, while loading the second url: the check for the awesome bar text fails, getting the text for the previous url, from the previous awesome bar activity. I have not seen this problem on the tegras or on any other device.

The issue arises from the code in this particular test that loads 2 urls back-to-back (to get the 2 entries in the history list). As soon as we receive DOMContentLoaded for the first url, the test clicks on the awesome bar to enter the 2nd url -- in doing so, the activity monitor trick we use in getActivityFromClick sometimes fails, and we get the wrong activity.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: wait for paint after loading

This patch uses PixelText.loadAndPaint to wait not just for DOMContentLoaded, but for paint completion before proceeding.

(I also noticed some checks for text like "Bookmark" -- changed this to "^Bookmark$" just to be more safe/explicit.)

Comment 2

[Geoff Brown [:gbrown]]

Expanding the scope of this bug -- with more testing, I see the same problem affecting other tests:
testAboutPage
testBookmark
testBookmarklets
testHistoryTab

Waiting for paint completion resolves all of these problems on the Galaxy Nexus.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: wait for paint after loading

This patch uses loadAndPaint instead of loadUrl for the affected tests.

Comment 4

[Geoff Brown [:gbrown]]

Good try run: https://tbpl.mozilla.org/?tree=Try&rev=4266b346aa54

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 653743 [details] [diff] [review]
wait for paint after loading

Review of attachment 653743 [details] [diff] [review]:
-----------------------------------------------------------------

good find.  These changes look pretty straightforward.  Are there any tests not using PixelTest now?

Comment 6

[Geoff Brown [:gbrown]]

(In reply to Joel Maher (:jmaher) from comment #5)
>  Are there any tests
> not using PixelTest now?

Yes, there are several (eg testAwesomebar). There are cases where we don't do much after loading a url, or do an unrelated task after loading, where we don't need to wait for page display.

Comment 7

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78d6548c9c23

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78d6548c9c23