784205 - On-device screenshots don't work (Failure arg 0 [nsIDOMDeviceStorage.addNamed]")

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Press HOME+power to take screenshot

I get the vibration feedback, but the screenshot doesn't appear in my /sdcard/DCIM.  This error looks relevant

I/GeckoDump(  106): XXX FIXME : Got a mozContentEvent: take-screenshot
E/GeckoConsole(  106): Content JS LOG at app://system.thisdomaindoesnotexist.org/js/screenshot.js:72 in ss_onMozChromeEvent: exception in screenshot handler [Exception... "Failure arg 0 [nsIDOMDeviceStorage.addNamed]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: app://system.thisdomaindoesnotexist.org/js/screenshot.js :: ss_onMozChromeEvent :: line 49"  data: no]

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

https://github.com/mozilla-b2g/gaia/issues/3620, for xref.

Comment 2

[David Flanagan [:djf]]

Attachment: patch

The problem was that sendChromeEvent in shell.js had been converted to use ObjectWrapper.wrap() on the detail object.  But that function can't correctly wrap Blobs.  And the screenshot module sends the screenshot to content as a blob.

This patch changes the screenshot module to use sendEvent() instead of sendChromeEvent, and manually sets __exposedProps__ on the detail object.

Fabrice, please note that this requires your fix to the reportCrash() bug before it can work correctly.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 653954 [details] [diff] [review]
patch

Review of attachment 653954 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed

::: b2g/chrome/content/shell.js
@@ +614,4 @@
>          context.DRAWWINDOW_USE_WIDGET_LAYERS;
>        context.drawWindow(window, 0, 0, width, height,
>                           'rgb(255,255,255)', flags);
> +      

Nit: whitespace

Comment 4

[David Flanagan [:djf]]

Attachment: patch with whitespace nit fixed

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb96c6485ef

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ecb96c6485ef