784256 - Generate id->event type switch case from nsEventNameList.h

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: untested WIP

Right now nsDOMEvent.h/.cpp have ugly lists for events.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

We can remove unused NS_SCROLLPORT_OVERFLOWCHANGED.
The only events which are now added to switch-case are before/afterprint.
But because those events are initialized using InitEvent, their type is known
and this doesn't affect to behavior.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#295

https://tbpl.mozilla.org/?tree=Try&rev=ed85af7a1a52

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 653654 [details] [diff] [review]
patch

Can we please at least document why some events are being excluded from ID_TO_EVENT?  Is it just the SMIL/SVG events?

We should probably #error if EVENT and so forth are defined when ID_TO_EVENT is defined, since we'll unconditionally undef them.

r=me for the rest, but I'd like to understand the SVG/SMIL stuff here....

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

It is because of the absolutely crazy event name <-> attribute mapping
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventListenerManager.cpp#685
http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/nsSVGElement.cpp#1448

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/2033b92222eb