Last Comment Bug 784282 - GC: Assert that cross-compartment pointers are wrapped when marking
: GC: Assert that cross-compartment pointers are wrapped when marking
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla17
Assigned To: Jon Coppeard (:jonco)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-21 02:19 PDT by Jon Coppeard (:jonco)
Modified: 2012-08-23 07:24 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proposed fix (1.24 KB, patch)
2012-08-21 09:16 PDT, Jon Coppeard (:jonco)
wmccloskey: review+
Details | Diff | Splinter Review

Description Jon Coppeard (:jonco) 2012-08-21 02:19:43 PDT
GC marking traverses pointers between reachable objects and is a convenient place to assert that there are no cross compartment pointers that are not wrapped.
Comment 1 Jon Coppeard (:jonco) 2012-08-21 09:16:04 PDT
Created attachment 653786 [details] [diff] [review]
Proposed fix
Comment 3 Ed Morley [:emorley] 2012-08-23 03:51:59 PDT
https://hg.mozilla.org/mozilla-central/rev/e8bf3b589c2d
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-08-23 06:10:06 PDT
> https://hg.mozilla.org/mozilla-central/rev/e8bf3b589c2d

Something weird happened to the indentation here...
Comment 5 Jon Coppeard (:jonco) 2012-08-23 07:24:15 PDT
(In reply to :Ms2ger from comment #4)
> > https://hg.mozilla.org/mozilla-central/rev/e8bf3b589c2d
> 
> Something weird happened to the indentation here...

Cheers, fixed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e98e33cb80d

Note You need to log in before you can comment on or make changes to this bug.