The default bug view has changed. See this FAQ.

Dummy test necessary for remote restart tests due to 0 passing tests

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: vladmaniac)

Tracking

unspecified

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox17 fixed, firefox-esr10 fixed)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

5 years ago
Our CI will mark a testrun as failed if no tests are passing. We have to add a dummy test to ensure that at least a single test passes. This is urgent and has to land across branches.
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 653728 [details] [diff] [review]
[default]patch v1.0

* adding a dummy test
* updated manifest
Attachment #653728 - Flags: review?(hskupin)
(Assignee)

Updated

5 years ago
Attachment #653728 - Flags: review?(dave.hunt)
(Assignee)

Comment 2

5 years ago
Created attachment 653729 [details] [diff] [review]
[mozilla-esr10] patch v1.0

* adding patch for mozilla-esr10 since the manifest file is different on this branch and we cannot backport the default patch here
Attachment #653729 - Flags: review?(hskupin)
(Reporter)

Comment 3

5 years ago
Comment on attachment 653728 [details] [diff] [review]
[default]patch v1.0

Review of attachment 653728 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/remote/restartTests/manifest.ini
@@ +9,5 @@
>  [include:testDiscoveryPane_installCollectionAddon/manifest.ini]
>  disabled = Bug 732353 - Disable all Discovery Pane tests due to unpredictable web dependencies
>  [include:testDiscoveryPane_installPickOfMonthAddon/manifest.ini]
>  disabled = Bug 657492 - 'Pick of the Month' add-ons are only compatible with Release and Beta builds
> +[include:testDummy/manifest.ini]

This should be put into the first line so we do not forget about it. Also add a comment via '#'

::: tests/remote/restartTests/testDummy/manifest.ini
@@ +1,1 @@
> +[testDummy.js]

Have you tested your patch? This will not work because restart tests expect test1.js here.
Attachment #653728 - Flags: review?(hskupin)
Attachment #653728 - Flags: review?(dave.hunt)
Attachment #653728 - Flags: review-
(Assignee)

Updated

5 years ago
Attachment #653729 - Flags: review?(dave.hunt)
(Reporter)

Comment 4

5 years ago
Comment on attachment 653729 [details] [diff] [review]
[mozilla-esr10] patch v1.0

You know that you shouldnt upload backport patches before the original patch has been fully reviewed.
Attachment #653729 - Attachment is obsolete: true
Attachment #653729 - Flags: review?(hskupin)
Attachment #653729 - Flags: review?(dave.hunt)
(Assignee)

Comment 5

5 years ago
Created attachment 653730 [details] [diff] [review]
patch v1.1 [checked-in]

fixed
Attachment #653728 - Attachment is obsolete: true
Attachment #653730 - Flags: review?(hskupin)
(Assignee)

Updated

5 years ago
Attachment #653730 - Flags: review?(dave.hunt)
(Reporter)

Updated

5 years ago
Attachment #653730 - Flags: review?(hskupin)
Attachment #653730 - Flags: review?(dave.hunt)
Attachment #653730 - Flags: review+
(Assignee)

Comment 6

5 years ago
Created attachment 653732 [details] [diff] [review]
[default]patch v1.2

* adding comment above as Henrik's iRC suggestions
Attachment #653730 - Attachment is obsolete: true
Attachment #653732 - Flags: review?(hskupin)
(Reporter)

Comment 7

5 years ago
Comment on attachment 653732 [details] [diff] [review]
[default]patch v1.2

As mentioned on IRC we are ok in having the comment below the include line.
Attachment #653732 - Attachment is obsolete: true
Attachment #653732 - Flags: review?(hskupin)
(Reporter)

Updated

5 years ago
Attachment #653730 - Attachment is obsolete: false
(Reporter)

Comment 8

5 years ago
Comment on attachment 653730 [details] [diff] [review]
patch v1.1 [checked-in]

http://hg.mozilla.org/qa/mozmill-tests/rev/d6220ab37aed (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/c2a9444b6012 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/8fa629ac5955 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/3bf833bd266a (release)
Attachment #653730 - Attachment description: [default]patch v1.1 → patch v1.1 [checked-in]
(Reporter)

Updated

5 years ago
Component: Mozmill Automation → Mozmill Tests
(Reporter)

Updated

5 years ago
status-firefox-esr10: --- → affected
status-firefox14: --- → fixed
status-firefox15: --- → fixed
status-firefox16: --- → fixed
status-firefox17: --- → fixed
(Assignee)

Comment 9

5 years ago
Created attachment 653734 [details] [diff] [review]
[mozilla-esr10] patch v1.1

* backport for Esr branch
Attachment #653734 - Flags: review?(hskupin)
(Reporter)

Updated

5 years ago
Attachment #653734 - Flags: review?(hskupin) → review+
(Reporter)

Comment 10

5 years ago
esr10:
http://hg.mozilla.org/qa/mozmill-tests/rev/8567de882eb7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.