784311 - Dummy test necessary for remote restart tests due to 0 passing tests

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Our CI will mark a testrun as failed if no tests are passing. We have to add a dummy test to ensure that at least a single test passes. This is urgent and has to land across branches.

Comment 1

[Maniac Vlad Florin (:vladmaniac)]

Attachment: [default]patch v1.0

* adding a dummy test
* updated manifest

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Attachment: [mozilla-esr10] patch v1.0

* adding patch for mozilla-esr10 since the manifest file is different on this branch and we cannot backport the default patch here

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 653728 [details] [diff] [review]
[default]patch v1.0

Review of attachment 653728 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/remote/restartTests/manifest.ini
@@ +9,5 @@
>  [include:testDiscoveryPane_installCollectionAddon/manifest.ini]
>  disabled = Bug 732353 - Disable all Discovery Pane tests due to unpredictable web dependencies
>  [include:testDiscoveryPane_installPickOfMonthAddon/manifest.ini]
>  disabled = Bug 657492 - 'Pick of the Month' add-ons are only compatible with Release and Beta builds
> +[include:testDummy/manifest.ini]

This should be put into the first line so we do not forget about it. Also add a comment via '#'

::: tests/remote/restartTests/testDummy/manifest.ini
@@ +1,1 @@
> +[testDummy.js]

Have you tested your patch? This will not work because restart tests expect test1.js here.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 653729 [details] [diff] [review]
[mozilla-esr10] patch v1.0

You know that you shouldnt upload backport patches before the original patch has been fully reviewed.

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

Attachment: patch v1.1 [checked-in]

fixed

Comment 6

[Maniac Vlad Florin (:vladmaniac)]

Attachment: [default]patch v1.2

* adding comment above as Henrik's iRC suggestions

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 653732 [details] [diff] [review]
[default]patch v1.2

As mentioned on IRC we are ok in having the comment below the include line.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 653730 [details] [diff] [review]
patch v1.1 [checked-in]

http://hg.mozilla.org/qa/mozmill-tests/rev/d6220ab37aed (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/c2a9444b6012 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/8fa629ac5955 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/3bf833bd266a (release)

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Attachment: [mozilla-esr10] patch v1.1

* backport for Esr branch

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

esr10:
http://hg.mozilla.org/qa/mozmill-tests/rev/8567de882eb7