Last Comment Bug 784311 - Dummy test necessary for remote restart tests due to 0 passing tests
: Dummy test necessary for remote restart tests due to 0 passing tests
Status: RESOLVED FIXED
:
Product: Mozilla QA
Classification: Other
Component: Mozmill Tests (show other bugs)
: unspecified
: All All
: P1 normal (vote)
: ---
Assigned To: Maniac Vlad Florin (:vladmaniac)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-21 05:33 PDT by Henrik Skupin (:whimboo)
Modified: 2012-08-21 06:24 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed
fixed
fixed
fixed


Attachments
[default]patch v1.0 (1.92 KB, patch)
2012-08-21 05:42 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review-
Details | Diff | Splinter Review
[mozilla-esr10] patch v1.0 (1.94 KB, patch)
2012-08-21 05:48 PDT, Maniac Vlad Florin (:vladmaniac)
no flags Details | Diff | Splinter Review
patch v1.1 [checked-in] (1.90 KB, patch)
2012-08-21 06:07 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review+
Details | Diff | Splinter Review
[default]patch v1.2 (1.90 KB, patch)
2012-08-21 06:11 PDT, Maniac Vlad Florin (:vladmaniac)
no flags Details | Diff | Splinter Review
[mozilla-esr10] patch v1.1 (1.92 KB, patch)
2012-08-21 06:21 PDT, Maniac Vlad Florin (:vladmaniac)
hskupin: review+
Details | Diff | Splinter Review

Description Henrik Skupin (:whimboo) 2012-08-21 05:33:27 PDT
Our CI will mark a testrun as failed if no tests are passing. We have to add a dummy test to ensure that at least a single test passes. This is urgent and has to land across branches.
Comment 1 Maniac Vlad Florin (:vladmaniac) 2012-08-21 05:42:02 PDT
Created attachment 653728 [details] [diff] [review]
[default]patch v1.0

* adding a dummy test
* updated manifest
Comment 2 Maniac Vlad Florin (:vladmaniac) 2012-08-21 05:48:21 PDT
Created attachment 653729 [details] [diff] [review]
[mozilla-esr10] patch v1.0

* adding patch for mozilla-esr10 since the manifest file is different on this branch and we cannot backport the default patch here
Comment 3 Henrik Skupin (:whimboo) 2012-08-21 05:48:29 PDT
Comment on attachment 653728 [details] [diff] [review]
[default]patch v1.0

Review of attachment 653728 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/remote/restartTests/manifest.ini
@@ +9,5 @@
>  [include:testDiscoveryPane_installCollectionAddon/manifest.ini]
>  disabled = Bug 732353 - Disable all Discovery Pane tests due to unpredictable web dependencies
>  [include:testDiscoveryPane_installPickOfMonthAddon/manifest.ini]
>  disabled = Bug 657492 - 'Pick of the Month' add-ons are only compatible with Release and Beta builds
> +[include:testDummy/manifest.ini]

This should be put into the first line so we do not forget about it. Also add a comment via '#'

::: tests/remote/restartTests/testDummy/manifest.ini
@@ +1,1 @@
> +[testDummy.js]

Have you tested your patch? This will not work because restart tests expect test1.js here.
Comment 4 Henrik Skupin (:whimboo) 2012-08-21 05:50:00 PDT
Comment on attachment 653729 [details] [diff] [review]
[mozilla-esr10] patch v1.0

You know that you shouldnt upload backport patches before the original patch has been fully reviewed.
Comment 5 Maniac Vlad Florin (:vladmaniac) 2012-08-21 06:07:23 PDT
Created attachment 653730 [details] [diff] [review]
patch v1.1 [checked-in]

fixed
Comment 6 Maniac Vlad Florin (:vladmaniac) 2012-08-21 06:11:50 PDT
Created attachment 653732 [details] [diff] [review]
[default]patch v1.2

* adding comment above as Henrik's iRC suggestions
Comment 7 Henrik Skupin (:whimboo) 2012-08-21 06:13:10 PDT
Comment on attachment 653732 [details] [diff] [review]
[default]patch v1.2

As mentioned on IRC we are ok in having the comment below the include line.
Comment 9 Maniac Vlad Florin (:vladmaniac) 2012-08-21 06:21:11 PDT
Created attachment 653734 [details] [diff] [review]
[mozilla-esr10] patch v1.1

* backport for Esr branch
Comment 10 Henrik Skupin (:whimboo) 2012-08-21 06:24:52 PDT
esr10:
http://hg.mozilla.org/qa/mozmill-tests/rev/8567de882eb7

Note You need to log in before you can comment on or make changes to this bug.