78432 - Fwd a msg as attachment & received with many different files

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P1)

Description

[Sheela Ravindran]

Buildid:2001-04-30-06 on mac, linux, win98

Forwarding a message as an attachment instead of inline and if the message that 
is being fowarded has an attachment(gif, jpeg, web page) when received is split 
into too many files.  Also trying to open one of them which reads as 
'part.1.2.1' lead to a crash on linux and mac. This is probably a regression

Forwarding message as an attachment can be changed in preference or even just by 
selecting file menu item Message|ForwardAs|->select As Attachment before 
sending.  

Steps to reproduce:
Compose a new message in mail
Attach a gif file or a web page
Send and receive
Select the mail that you just received
Go to file menu Message|forward as|attachment
The compose window comes up and you will see the message is attached in the 
attachment area
send and receive

Acutal Result:  After receiving click on the attachment clip I saw the message 
was split into three different parts and each one could be opened and saved. 
(if you attached a web page which I did in my case)
www.cnn.com.html-This opened the web page that was attached in the browser
Part 1.2.1-Trying to open this crashed.
attach web page-this was my subject of the message and when opened displayed the 
message 

Expected result:  None of the above that I have seen with previous builds or 
even 6.0 or 4.x.  The whole message was just one file and had the subject as the 
file name when opened in browser had both page or images displayed with the 
message.

Comment 1

[Sheela Ravindran]

change qa contact to myself.  Adding keywords.  Nominating for nsbeta1 because
trying to open of these files leads to a crash. 
Stack trace and the incident id for the crash:  29870011
 
   NECKO.DLL + 0x13c18 (0x60773c18) 
                                        
     
   NECKO.DLL + 0x13fd1 (0x60773fd1) 
                                        
     
   URILDR.DLL + 0x1b88 (0x60ac1b88) 
                                        
     
   EMITTER.DLL + 0x3eb3 (0x601b3eb3) 
                                        
     
   XPCOM.DLL + 0x9a0d (0x60ea9a0d) 
                                        
     
   XPCOM.DLL + 0x12bef (0x60eb2bef) 
                                        
     
   XPCOM.DLL + 0x2f618 (0x60ecf618) 
                                        
     
   MIME.DLL + 0xe926 (0x6057e926) 
                                        
     
   MIME.DLL + 0xe926 (0x6057e926) 
                                        
     
   MIME.DLL + 0x1474 (0x60571474) 
                                        
     
   MIME.DLL + 0x13c0 (0x605713c0) 
                                        
     
   MIME.DLL + 0xfd80 (0x6057fd80) 
                                        
     
   MIME.DLL + 0x13b01 (0x60583b01) 
                                        
     
   MIME.DLL + 0x1a54 (0x60571a54) 
                                        
     
   MIME.DLL + 0xfa24 (0x6057fa24) 
                                        
     
   MIME.DLL + 0x1110c (0x6058110c) 
                                        
     
   MIME.DLL + 0x13b01 (0x60583b01) 
                                        
     
   MIME.DLL + 0x1a54 (0x60571a54) 
                                        
     
   MIME.DLL + 0xfa24 (0x6057fa24) 
                                        
     
   MIME.DLL + 0x10fdc (0x60580fdc) 
                                        
     
   MIME.DLL + 0xfddb (0x6057fddb) 
                                        
     
   MIME.DLL + 0xfddb (0x6057fddb) 
                                        
     
   MIME.DLL + 0x13b01 (0x60583b01) 
                                        
     
   MIME.DLL + 0x1a54 (0x60571a54) 
                                        
     
   MIME.DLL + 0xfa24 (0x6057fa24) 
                                        
     
   MIME.DLL + 0x1110c (0x6058110c) 
                                        
     
   MIME.DLL + 0x13b01 (0x60583b01) 
                                        
     
   MIME.DLL + 0x1a54 (0x60571a54) 
                                        
     
   MIME.DLL + 0xfa24 (0x6057fa24) 
                                        
     
   MIME.DLL + 0x10fdc (0x60580fdc) 
                                        
     
   XPCOM.DLL + 0x8b5e (0x60ea8b5e) 
                                        
     
   MIME.DLL + 0x6381 (0x60576381) 
                                        
     
   MIME.DLL + 0x6381 (0x60576381) 
                                        
     
   MSGLOCAL.DLL + 0xf610 (0x606ef610) 
                                        
     
   MSGLOCAL.DLL + 0xf856 (0x606ef856) 
                                        
     
   MSGBSUTL.DLL + 0x5114 (0x60da5114) 
                                        
     
   NECKO.DLL + 0x209a0 (0x607809a0) 
                                        
     
   XPCOM.DLL + 0x5612 (0x60ea5612) 
                                        
     
   XPCOM.DLL + 0x79fd (0x60ea79fd) 
                                        
     
   XPCOM.DLL + 0x83ee (0x60ea83ee) 
                                        
     
   KERNEL32.DLL + 0x24407 (0xbff94407) 
                                        
     
   0x00688b5a 
                                        

Comment 2

[scottputterman]

marking nsbeta1+

Comment 3

[Jean-Francois Ducarroz]

I am not able to reproduc the crash with today's build however I can see the
problem with the multiple attachment. In 4.x, we show only the top level
attachment. That means in case of a forward as attachment, the only attachment
should be the original message itself and not it's parts.

Comment 4

[Jean-Francois Ducarroz]

Attachment: Proposed fix, V1

Comment 5

[varada]

r=varada

Comment 6

[Scott MacGregor]

sr=mscott

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 8

[Sheela Ravindran]

verified,
2001051506-win98
2001051508-mac
2001051508-linux