In Unix version, Const.SEEK_START should be Const.SEEK_SET

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

unspecified
mozilla18
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

No description provided.
Posted file Companion testsuite (obsolete) —
Attachment #653775 - Flags: review?(nfroyd)
Posted patch Companion testsuite (obsolete) — Splinter Review
Attachment #653775 - Attachment is obsolete: true
Attachment #653775 - Flags: review?(nfroyd)
Attachment #653784 - Flags: review?(nfroyd)
Attachment #653784 - Flags: review?(nfroyd) → review+
Comment on attachment 653773 [details] [diff] [review]
Fixing a typo in the Unix implementation

Review of attachment 653773 [details] [diff] [review]:
-----------------------------------------------------------------

Mea culpa.

::: toolkit/components/osfile/osfile_unix_front.jsm
@@ +145,2 @@
>         if (whence === undefined) {
> +         whence = Const.SEEK_SET;

Ah, love the confusion between slightly-differently-named sets of constants.

@@ +147,2 @@
>         }
> +       LOG("setPosition", pos, whence);

I don't think the LOG calls in this function are worth keeping around.
Attachment #653773 - Flags: review?(nfroyd) → review+
Summary: In Unix version, Const.SEEK_START should be Const.SEEK_END → In Unix version, Const.SEEK_START should be Const.SEEK_SET
Attachment #653784 - Attachment is obsolete: true
Attachment #655962 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/44cfdb8eba09
https://hg.mozilla.org/mozilla-central/rev/054229ba8fd6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.