784373 - In Unix version, Const.SEEK_START should be Const.SEEK_SET

Status: RESOLVED FIXED

(Toolkit :: OS.File, defect)

Comment 1

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Fixing a typo in the Unix implementation

Comment 2

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Companion testsuite

Comment 3

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Companion testsuite

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 653773 [details] [diff] [review]
Fixing a typo in the Unix implementation

Review of attachment 653773 [details] [diff] [review]:
-----------------------------------------------------------------

Mea culpa.

::: toolkit/components/osfile/osfile_unix_front.jsm
@@ +145,2 @@
>         if (whence === undefined) {
> +         whence = Const.SEEK_SET;

Ah, love the confusion between slightly-differently-named sets of constants.

@@ +147,2 @@
>         }
> +       LOG("setPosition", pos, whence);

I don't think the LOG calls in this function are worth keeping around.

Comment 5

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Fixing a typo in the Unix implementation

Comment 6

[David Teller [:Yoric] (please use "needinfo")]

Attachment: Companion testsuite

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=a380ec7825ed

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #7)
> https://tbpl.mozilla.org/?tree=Try&rev=a380ec7825ed

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfdb8eba09
https://hg.mozilla.org/integration/mozilla-inbound/rev/054229ba8fd6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/44cfdb8eba09
https://hg.mozilla.org/mozilla-central/rev/054229ba8fd6