Closed Bug 784373 Opened 13 years ago Closed 13 years ago

In Unix version, Const.SEEK_START should be Const.SEEK_SET

Categories

(Toolkit Graveyard :: OS.File, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: Yoric, Assigned: Yoric)

Details

Attachments

(2 files, 3 obsolete files)

No description provided.
Attached file Companion testsuite (obsolete) —
Attachment #653775 - Flags: review?(nfroyd)
Attached patch Companion testsuite (obsolete) — Splinter Review
Attachment #653775 - Attachment is obsolete: true
Attachment #653775 - Flags: review?(nfroyd)
Attachment #653784 - Flags: review?(nfroyd)
Attachment #653784 - Flags: review?(nfroyd) → review+
Comment on attachment 653773 [details] [diff] [review] Fixing a typo in the Unix implementation Review of attachment 653773 [details] [diff] [review]: ----------------------------------------------------------------- Mea culpa. ::: toolkit/components/osfile/osfile_unix_front.jsm @@ +145,2 @@ > if (whence === undefined) { > + whence = Const.SEEK_SET; Ah, love the confusion between slightly-differently-named sets of constants. @@ +147,2 @@ > } > + LOG("setPosition", pos, whence); I don't think the LOG calls in this function are worth keeping around.
Attachment #653773 - Flags: review?(nfroyd) → review+
Summary: In Unix version, Const.SEEK_START should be Const.SEEK_END → In Unix version, Const.SEEK_START should be Const.SEEK_SET
Attachment #653784 - Attachment is obsolete: true
Attachment #655962 - Flags: review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: