Closed
Bug 784373
Opened 13 years ago
Closed 13 years ago
In Unix version, Const.SEEK_START should be Const.SEEK_SET
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: Yoric, Assigned: Yoric)
Details
Attachments
(2 files, 3 obsolete files)
1.01 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
1.50 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #653773 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #653775 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #653775 -
Attachment is obsolete: true
Attachment #653775 -
Flags: review?(nfroyd)
Attachment #653784 -
Flags: review?(nfroyd)
![]() |
||
Updated•13 years ago
|
Attachment #653784 -
Flags: review?(nfroyd) → review+
![]() |
||
Comment 4•13 years ago
|
||
Comment on attachment 653773 [details] [diff] [review]
Fixing a typo in the Unix implementation
Review of attachment 653773 [details] [diff] [review]:
-----------------------------------------------------------------
Mea culpa.
::: toolkit/components/osfile/osfile_unix_front.jsm
@@ +145,2 @@
> if (whence === undefined) {
> + whence = Const.SEEK_SET;
Ah, love the confusion between slightly-differently-named sets of constants.
@@ +147,2 @@
> }
> + LOG("setPosition", pos, whence);
I don't think the LOG calls in this function are worth keeping around.
Attachment #653773 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•13 years ago
|
Summary: In Unix version, Const.SEEK_START should be Const.SEEK_END → In Unix version, Const.SEEK_START should be Const.SEEK_SET
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #653773 -
Attachment is obsolete: true
Attachment #655961 -
Flags: review+
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #653784 -
Attachment is obsolete: true
Attachment #655962 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
(In reply to Ryan VanderMeulen from comment #7)
> https://tbpl.mozilla.org/?tree=Try&rev=a380ec7825ed
Green on Try.
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfdb8eba09
https://hg.mozilla.org/integration/mozilla-inbound/rev/054229ba8fd6
Flags: in-testsuite+
Keywords: checkin-needed
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44cfdb8eba09
https://hg.mozilla.org/mozilla-central/rev/054229ba8fd6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•