78445 - Crash if you close the window during onLoad DOM event.

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Jean-Francois Ducarroz]

The progress dialog used during message compose send or save sometime need to
close itsef when it process an onLoad event. The problem is that we start
crashing recently when doing that, use to work fine. The crash occurs in
DocumentViewerImpl::LoadComplete when calling mPreshell->UnsuppressPainting
because the documentViewer object itself has been destroyed! Looks like we need
to protect ourself againg "auto-destruction" by adding addref/release in this
function. I'll attach a testcase...

Comment 1

[Jean-Francois Ducarroz]

Attachment: Sample xul window that reproduce the problem

Comment 2

[Jean-Francois Ducarroz]

Save the attachment above as .xul and open it in the browser, yoy will crash.

nominating nsbeta1 as this is blocking the landing of the progress dialog in
mailnews.

Comment 3

[Jean-Francois Ducarroz]

nominating nsbeta1 as this is blocking bug 28348. David, if you want, I can take
care of it!

Comment 4

[Jean-Francois Ducarroz]

Attachment: proposed fix, v1

Comment 5

[David Hyatt]

sr=hyatt

Comment 6

[Jean-Francois Ducarroz]

R=sspitzer

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 8

[Chad Austin]

verified

win2k: 2001060509
linux: 2001060511
macos: 2001060503