Closed Bug 784472 Opened 12 years ago Closed 12 years ago

Unable to invoke the context menu on selected text

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox16 unaffected, firefox17 verified)

VERIFIED FIXED
Firefox 17
Tracking Status
firefox16 --- unaffected
firefox17 --- verified

People

(Reporter: aaronmt, Assigned: mcomella)

References

Details

(Keywords: regression)

Attachments

(1 file)

Select some text, and tap and hold on it. Nothing happens.

--
Samsung Galaxy Nexus (Android 4.1.1)
20120821054201
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
I called the function without the full param list.
Attachment #654289 - Flags: review?(wjohnston)
The problem stems from me not rebasing properly. See the initial patch here:

https://hg.mozilla.org/try/rev/e0c06adb6bb1
Comment on attachment 654289 [details] [diff] [review]
Patch

Review of attachment 654289 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. The code just changed underneath you. I should have noticed and said something.
Attachment #654289 - Flags: review?(wjohnston) → review+
Well, it was hard to see considering I rebased only an hour before I posted checkin-needed (or at least I think so). Solution? Commit my own changes. x_x

Hypocrisy: Saying that as I add checkin-needed. :D
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f20dca58350
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Verified fixed.

Build: Firefox 17.0a2 (2012-09-03)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: