Closed
Bug 784472
Opened 12 years ago
Closed 12 years ago
Unable to invoke the context menu on selected text
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(firefox16 unaffected, firefox17 verified)
VERIFIED
FIXED
Firefox 17
Tracking | Status | |
---|---|---|
firefox16 | --- | unaffected |
firefox17 | --- | verified |
People
(Reporter: aaronmt, Assigned: mcomella)
References
Details
(Keywords: regression)
Attachments
(1 file)
976 bytes,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Select some text, and tap and hold on it. Nothing happens. -- Samsung Galaxy Nexus (Android 4.1.1) 20120821054201
Reporter | ||
Updated•12 years ago
|
status-firefox16:
--- → unaffected
Reporter | ||
Comment 1•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d5fab9ef16a4&tochange=016e27967434
Blocks: 777450
Keywords: regressionwindow-wanted
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
I called the function without the full param list.
Attachment #654289 -
Flags: review?(wjohnston)
Assignee | ||
Comment 3•12 years ago
|
||
The problem stems from me not rebasing properly. See the initial patch here: https://hg.mozilla.org/try/rev/e0c06adb6bb1
Comment 4•12 years ago
|
||
Comment on attachment 654289 [details] [diff] [review] Patch Review of attachment 654289 [details] [diff] [review]: ----------------------------------------------------------------- Heh. The code just changed underneath you. I should have noticed and said something.
Attachment #654289 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Well, it was hard to see considering I rebased only an hour before I posted checkin-needed (or at least I think so). Solution? Commit my own changes. x_x Hypocrisy: Saying that as I add checkin-needed. :D
Keywords: checkin-needed
Comment 6•12 years ago
|
||
Green on Try. https://tbpl.mozilla.org/?tree=Try&rev=2225f75a2f66 https://hg.mozilla.org/integration/mozilla-inbound/rev/7f20dca58350
Flags: in-testsuite-
Keywords: checkin-needed
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f20dca58350
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Updated•12 years ago
|
Comment 8•12 years ago
|
||
Verified fixed. Build: Firefox 17.0a2 (2012-09-03) Device: Samsung Galaxy Nexus OS: Android 4.1.1
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•