The default bug view has changed. See this FAQ.

[WebAPI] WebTelephony: Develop automated tests to verify the various call state transitions

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

unspecified
mozilla17
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(10 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Develop more B2G WebTelephony WebAPI tests, to verify the various call state transitions.  Refer to the telephony call state transitions diagram found on the WebTelephony API wiki page: https://wiki.mozilla.org/WebAPI/WebTelephony
(Assignee)

Comment 1

5 years ago
Created attachment 654319 [details] [diff] [review]
Patch 1 of 10
Attachment #654319 - Flags: review?(jgriffin)
(Assignee)

Comment 2

5 years ago
Adding 10 new B2G WebTelephony tests - each test as its own patch.  The last patch will include the changes to the manifest.ini.
(Assignee)

Comment 3

5 years ago
Created attachment 654321 [details] [diff] [review]
Patch 2 of 10
Attachment #654321 - Flags: review?(jgriffin)
(Assignee)

Comment 4

5 years ago
Created attachment 654322 [details] [diff] [review]
Patch 3 of 10
Attachment #654322 - Flags: review?(jgriffin)
(Assignee)

Comment 5

5 years ago
Created attachment 654323 [details] [diff] [review]
Patch 4 of 10
Attachment #654323 - Flags: review?(jgriffin)
(Assignee)

Comment 6

5 years ago
Created attachment 654325 [details] [diff] [review]
Patch 5 of 10
Attachment #654325 - Flags: review?(jgriffin)
(Assignee)

Comment 7

5 years ago
Created attachment 654326 [details] [diff] [review]
Patch 6 of 10
Attachment #654326 - Flags: review?(jgriffin)
(Assignee)

Comment 8

5 years ago
Created attachment 654327 [details] [diff] [review]
Patch 7 of 10
Attachment #654327 - Flags: review?(jgriffin)
(Assignee)

Comment 9

5 years ago
Created attachment 654328 [details] [diff] [review]
Patch 8 of 10
Attachment #654328 - Flags: review?(jgriffin)
(Assignee)

Comment 10

5 years ago
Created attachment 654329 [details] [diff] [review]
Patch 9 of 10
Attachment #654329 - Flags: review?(jgriffin)
(Assignee)

Comment 11

5 years ago
Created attachment 654330 [details] [diff] [review]
Patch 10 of 10
Attachment #654330 - Flags: review?(jgriffin)
Attachment #654319 - Flags: review?(jgriffin) → review+
Attachment #654321 - Flags: review?(jgriffin) → review+
Attachment #654322 - Flags: review?(jgriffin) → review+
Attachment #654323 - Flags: review?(jgriffin) → review+
Attachment #654325 - Flags: review?(jgriffin) → review+
Attachment #654326 - Flags: review?(jgriffin) → review+
Attachment #654327 - Flags: review?(jgriffin) → review+
Attachment #654328 - Flags: review?(jgriffin) → review+
Attachment #654329 - Flags: review?(jgriffin) → review+
Comment on attachment 654330 [details] [diff] [review]
Patch 10 of 10

Review of attachment 654330 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_outgoing_remote_hangup_held.js
@@ +38,5 @@
> +  runEmulatorCmd("gsm list", function(result) {
> +    log("Call list is now: " + result);
> +    is(result[0], "outbound to  " + outNumber + " : unknown");
> +    is(result[1], "OK");
> +    verifyAlerting();

Does this work reliably?  This sets up the onalerting event handler after the dial command has had a chance to do its thing.  I would imagine there is a chance that the alerting event could happen before the event handler is set up, since waiting for the runEmulatorCmd callback gives it a window in which events can be processed.  It's probably better to structure this part something like https://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_outgoing_hangup_alerting.js#28.  This applies to the other tests that use onalerting as well.
Attachment #654330 - Flags: review?(jgriffin) → review-
(Assignee)

Comment 13

5 years ago
Oh, good point - I will make the changes, thanks Jonathan!
(Assignee)

Comment 14

5 years ago
Created attachment 655135 [details] [diff] [review]
Patch 9 of 10 VER2

Fixed the test in patch 9, attached new / replacement patch 9.
Attachment #654329 - Attachment is obsolete: true
Attachment #655135 - Flags: review?(jgriffin)
(Assignee)

Comment 15

5 years ago
Created attachment 655136 [details] [diff] [review]
Patch 10 of 10 VER2

Fixed test in patch 10, attached replacement patch 10.
Attachment #654330 - Attachment is obsolete: true
Attachment #655136 - Flags: review?(jgriffin)
Attachment #655135 - Flags: review?(jgriffin) → review+
Comment on attachment 655136 [details] [diff] [review]
Patch 10 of 10 VER2

Review of attachment 655136 [details] [diff] [review]:
-----------------------------------------------------------------

Looks much better, thanks!  I'll land this shortly.
Attachment #655136 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/72e95bee76fa
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/72e95bee76fa
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.