784509 - [WebAPI] WebTelephony: Develop automated tests to verify the various call state transitions

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Robert Wood [:rwood]]

Develop more B2G WebTelephony WebAPI tests, to verify the various call state transitions.  Refer to the telephony call state transitions diagram found on the WebTelephony API wiki page: https://wiki.mozilla.org/WebAPI/WebTelephony

Comment 1

[Robert Wood [:rwood]]

Attachment: Patch 1 of 10

Comment 2

[Robert Wood [:rwood]]

Adding 10 new B2G WebTelephony tests - each test as its own patch.  The last patch will include the changes to the manifest.ini.

Comment 3

[Robert Wood [:rwood]]

Attachment: Patch 2 of 10

Comment 4

[Robert Wood [:rwood]]

Attachment: Patch 3 of 10

Comment 5

[Robert Wood [:rwood]]

Attachment: Patch 4 of 10

Comment 6

[Robert Wood [:rwood]]

Attachment: Patch 5 of 10

Comment 7

[Robert Wood [:rwood]]

Attachment: Patch 6 of 10

Comment 8

[Robert Wood [:rwood]]

Attachment: Patch 7 of 10

Comment 9

[Robert Wood [:rwood]]

Attachment: Patch 8 of 10

Comment 10

[Robert Wood [:rwood]]

Attachment: Patch 9 of 10

Comment 11

[Robert Wood [:rwood]]

Attachment: Patch 10 of 10

Comment 12

[Jonathan Griffin (:jgriffin)]

Comment on attachment 654330 [details] [diff] [review]
Patch 10 of 10

Review of attachment 654330 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_outgoing_remote_hangup_held.js
@@ +38,5 @@
> +  runEmulatorCmd("gsm list", function(result) {
> +    log("Call list is now: " + result);
> +    is(result[0], "outbound to  " + outNumber + " : unknown");
> +    is(result[1], "OK");
> +    verifyAlerting();

Does this work reliably?  This sets up the onalerting event handler after the dial command has had a chance to do its thing.  I would imagine there is a chance that the alerting event could happen before the event handler is set up, since waiting for the runEmulatorCmd callback gives it a window in which events can be processed.  It's probably better to structure this part something like https://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_outgoing_hangup_alerting.js#28.  This applies to the other tests that use onalerting as well.

Comment 13

[Robert Wood [:rwood]]

Oh, good point - I will make the changes, thanks Jonathan!

Comment 14

[Robert Wood [:rwood]]

Attachment: Patch 9 of 10 VER2

Fixed the test in patch 9, attached new / replacement patch 9.

Comment 15

[Robert Wood [:rwood]]

Attachment: Patch 10 of 10 VER2

Fixed test in patch 10, attached replacement patch 10.

Comment 16

[Jonathan Griffin (:jgriffin)]

Comment on attachment 655136 [details] [diff] [review]
Patch 10 of 10 VER2

Review of attachment 655136 [details] [diff] [review]:
-----------------------------------------------------------------

Looks much better, thanks!  I'll land this shortly.

Comment 17

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72e95bee76fa

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72e95bee76fa