Closed Bug 784558 Opened 7 years ago Closed 7 years ago

[Page Thumbnails] single thumbnail removal doesn't work anymore when the corresponding site is removed from history

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 17
Tracking Status
firefox16 --- unaffected

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Attached patch patch v1 (obsolete) — Splinter Review
The last iteration of the patch for bug 754671 introduced the "removeFiles" method in the PageThumbsWorker. Unfortunately Storage.remove() relied on the old "removeFile" method and should now silently fail.

The test I wrote for exactly this was wrong so we didn't catch that. I re-added the "removeFile" method to remove single files and fixed the test as well.
Attachment #654032 - Flags: review?(felipc)
Attachment #654032 - Flags: review?(felipc) → review+
Comment on attachment 654032 [details] [diff] [review]
patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 754671
User impact if declined: removing a site from history doesn't remove its thumbnails
Testing completed (on m-c, etc.): should be in tomorrow's nightly
Risk to taking this patch (and alternatives if risky): low risk, need it for bug 754671 on Aurora
String or UUID changes made by this patch: none.

We need this patch on Aurora as well in combination with the patch from bug 754671.
Attachment #654032 - Flags: approval-mozilla-aurora?
Comment on attachment 654032 [details] [diff] [review]
patch v1

[Triage Comment]
We're letting bug 754671 ride the trains, so no need to uplift to Aurora 16.
Attachment #654032 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Bah, backed out because the test times out on Windows. Seems to be a file lock issue.

https://hg.mozilla.org/integration/fx-team/rev/fd6973289931
Whiteboard: [fixed-in-fx-team]
Marking Fx 16 as unaffected because I fixed the backported patch from bug 754671 to just use "removeFiles" for now.
Ok, I found the failure. Try looks green now:

https://tbpl.mozilla.org/?tree=Try&rev=b885539b32bb

Going to clean the patch up and upload it.
Attached patch patch v2Splinter Review
Fixed the windows timeout and cleaned up the test.

It was timing out on Windows because Windows sometimes locks the files and we need to re-try removing those files. The missing part was re-adding the URL to the browser history so that the history observer's onDeleteURI() is called again.
Attachment #654032 - Attachment is obsolete: true
Attachment #655124 - Flags: review?(felipc)
Attachment #655124 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/89e186d2a171
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.