784574 - Cannot submit apps that contain a comma-separated list in the orientation property of the app manifest

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[Jason Smith [:jsmith]]

Steps:

1. Go to https://marketplace.mozilla.org/en-US/developers/submit/app/manifest
2. Submit the app here - http://lamb4197.testmanifest.com/manifest.webapp

Expected:

The app manifest should validate with no errors.

Actual:

The app manifest fails to validate indicating that the value is invalid. This isn't right - the orientation property of the app manifest allows for a comma-separated list of multiple values. See http://mozilla.github.com/webapps-spec/#optional-properties for more information.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Although the spec specifies comma-separated list, why is it not an actual JSON array/list? Everything else seems to be: http://f.cl.ly/items/1g1f2p0Y2j3K0o0L270c/Screen%20shot%202012-08-21%20at%208.16.16%20PM.png

That seems inconsistent to me.

Comment 2

[Anant Narayanan [:anant]]

I agree, an array of strings makes more sense. There's really no point to having them be comma-seperated, it makes parsing the manifest harder that it has to be.

I'll make a post on dev-webapps, and if there are no major objections, we'll make the switch.

Comment 3

[Mounir Lamouri (:mounir)]

The backend is now ready to take an array of strings in addition of a string. I guess the manifest should do the same now.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Mounir Lamouri (:mounir) from comment #3)
> The backend is now ready to take an array of strings in addition of a
> string. I guess the manifest should do the same now.

I already tested that in one of the previous bugs - that support hasn't landed for FF OS, and I know it doesn't work on FF Android per a comment I received from Wes.

- https://github.com/mozilla-b2g/gaia/issues/4701 <-- FF OS relevant bug

Comment 5

[Mounir Lamouri (:mounir)]

Jason, as I understand it, the purpose of this bug is to add the feature to the manifest syntax now that it has been added to the API.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Mounir Lamouri (:mounir) from comment #5)
> Jason, as I understand it, the purpose of this bug is to add the feature to
> the manifest syntax now that it has been added to the API.

Oh, this bug is about updating the validator to accept app manifests with multiple orientations. We need a separate bug for updating the manifest syntax with the mozapps API. That was the intention of filing #4701 in github, as I thought the root cause of the problem was in Gaia (although I could be incorrect).

Comment 7

[Mounir Lamouri (:mounir)]

That's the root cause for B2G, not for Android.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Mounir Lamouri (:mounir) from comment #7)
> That's the root cause for B2G, not for Android.

Right. I filed bug 792876 for Android support.

Comment 9

[Matt Basta [:basta]]

Merged in the validator:

https://github.com/mozilla/app-validator/commit/75eac85bd997f7165422bee942c5875c6e5420dc