784577 - Adding a new locale fails to complete the repack

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg ach for Firefox 15.0b6:

The command that fails is
command: START
command: perl ../../../tools/update-packaging/unwrap_full_update.pl ../../../..//None
where None should be the name of the earlier complete mar file. This is a result of
Downloading http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/15.0b4-candidates/build1/update/linux-i686/ach/firefox-15.0b4.complete.mar to firefox-15.0b4.ach.complete.mar
Got 404. Skipping http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/15.0b4-candidates/build1/update/linux-i686/ach/firefox-15.0b4.complete.mar
files which don't exist because this is the first time we built the locale.

We need to handle this case gracefully somehow, and still upload the installer + complete mar for the new locale.

Comment 1

[Rail Aliiev [:rail]]

Attachment: don't create partials for new locales

This patch "should just work". If there is rush, feel free to review instead of Ben.

We used the same logic before: http://hg.mozilla.org/build/tools/file/5292d9a3c619/lib/python/build/l10n.py#l84

diff with -b (ignore white space changes) shows only 2 line change: https://gist.github.com/3422277

Comment 2

[Axel Hecht [:Pike]]

FTR, we've added new locales during the beta cycles for 5, 6, 8, and 10 before, 

http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=88888694839a
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=22451c634108
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=e25c5612ad5c
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=402afd561056
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=3510d7f90498

so this seems to be a regression.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 654077 [details] [diff] [review]
don't create partials for new locales

Damn =(. Thanks for the fix Rail.

Comment 4

[[e-mail] (:bhearsum)]

This fix worked.

Comment 5

[Rail Aliiev [:rail]]

Attachment: Add warning when skipping partial mar creation

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 654204 [details] [diff] [review]
Add warning when skipping partial mar creation

http://hg.mozilla.org/build/tools/rev/beea3b219caa