Closed
Bug 784683
Opened 12 years ago
Closed 12 years ago
Remove useless h1 element when getting article title
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(firefox16 verified)
VERIFIED
FIXED
Firefox 17
| Tracking | Status | |
|---|---|---|
| firefox16 | --- | verified |
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No need to enclose the title in a h1 element as we only use the text anyway.
Attachment #654216 -
Flags: review?(mark.finkle)
|
||
Updated•12 years ago
|
Attachment #654216 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 654216 [details] [diff] [review]
Remove useless h1 node around title
[Approval Request Comment]
User impact if declined: Useless memory usage, unnecessary code.
Testing completed (on m-c, etc.): Landed in m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just removes unnecessary code.
String or UUID changes made by this patch: None.
Attachment #654216 -
Flags: approval-mozilla-aurora?
|
||
Updated•12 years ago
|
Attachment #654216 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed to mozilla-aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/bd8d5ac3a368
|
||
Updated•12 years ago
|
status-firefox16:
--- → fixed
|
||
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•