Closed Bug 784683 Opened 9 years ago Closed 9 years ago

Remove useless h1 element when getting article title

Categories

(Firefox for Android Graveyard :: Reader View, defect)

Product:
Firefox for Android Graveyard
Component:
Reader View
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox16 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 17
Tracking Flags:
Tracking Status
firefox16 --- verified

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(1 file)

Remove useless h1 node around title
1.49 KB, patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
No need to enclose the title in a h1 element as we only use the text anyway.
Attachment #654216 - Flags: review?(mark.finkle)
Attachment #654216 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/e97800e74b63
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment on attachment 654216 [details] [diff] [review]
Remove useless h1 node around title

[Approval Request Comment]
User impact if declined: Useless memory usage, unnecessary code.
Testing completed (on m-c, etc.): Landed in m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just removes unnecessary code.
String or UUID changes made by this patch: None.
Attachment #654216 - Flags: approval-mozilla-aurora?
Attachment #654216 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
status-firefox16: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.