Remove useless h1 element when getting article title

VERIFIED FIXED in Firefox 16

Status

()

Product:
Firefox for Android
Component:
Reader View
Type:
defect
Status:
VERIFIED FIXED
Opened:
7 years ago
Updated:
3 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

Version:
unspecified
Target:
Firefox 17
Platform:
All
Android
Points:
---

Firefox Tracking Flags

(firefox16 verified)

Details

Attachments

(1 attachment)

Remove useless h1 node around title
1.49 KB, patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Assignee

Description

•
7 years ago 
No need to enclose the title in a h1 element as we only use the text anyway.
Attachment #654216 - Flags: review?(mark.finkle)
Attachment #654216 - Flags: review?(mark.finkle) → review+

Comment 2

•
7 years ago 
https://hg.mozilla.org/mozilla-central/rev/e97800e74b63
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
 Assignee

Comment 3

•
7 years ago 
Comment on attachment 654216 [details] [diff] [review]
Remove useless h1 node around title

[Approval Request Comment]
User impact if declined: Useless memory usage, unnecessary code.
Testing completed (on m-c, etc.): Landed in m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just removes unnecessary code.
String or UUID changes made by this patch: None.
Attachment #654216 - Flags: approval-mozilla-aurora?
Attachment #654216 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
status-firefox16: fixed → verified
You need to log in before you can comment on or make changes to this bug.