don't depend on oldVersion in mobile release repacks

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Aki says that we don't need the code that does this right now.
(Assignee)

Comment 1

5 years ago
Created attachment 654231 [details] [diff] [review]
rip out old* references from android repack mozharness scripts

If we end up wanting this back we can add a partialUpdates variable to the release config instead.
Attachment #654231 - Flags: review?(aki)
(Assignee)

Comment 2

5 years ago
Comment on attachment 654231 [details] [diff] [review]
rip out old* references from android repack mozharness scripts

Aki is out this week. Can you review this, Rail? I still want Aki to look at it, but we need to land before 15.0.
Attachment #654231 - Flags: review?(rail)
(Assignee)

Comment 3

5 years ago
Created attachment 654262 [details] [diff] [review]
remove old* again

We can remove these again once the mozharness patch lands.
Attachment #654262 - Flags: review?(rail)
Comment on attachment 654231 [details] [diff] [review]
rip out old* references from android repack mozharness scripts

Review of attachment 654231 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/release.py
@@ +50,2 @@
>                          'ftp_server', 'ftp_user', 'ftp_ssh_key',
>                          'aus_server', 'aus_user', 'aus_ssh_key',):

A nit. Could you rewrap this when land.

::: scripts/sign_android.py
@@ +103,1 @@
>       ['--buildnum',],

You can drop old_buildnum as well.
Attachment #654231 - Flags: review?(rail) → review+
Attachment #654262 - Flags: review?(rail) → review+

Comment 5

5 years ago
Comment on attachment 654231 [details] [diff] [review]
rip out old* references from android repack mozharness scripts

I think this would be cleaner if we ripped out the create snippets and upload snippets actions from sign_android.py entirely, rather than have them there but crippled.

That means removing them from all_actions and removing the create_snippets() and upload_snippets() methods from sign_android.py.

I think this is an acceptable first step, however, since we're not running those two actions currently.  If you want me to write the patch to remove them entirely, I can do that.
Attachment #654231 - Flags: review?(aki) → review+
(Assignee)

Updated

5 years ago
Blocks: 575317
(Assignee)

Comment 6

5 years ago
(In reply to Aki Sasaki [:aki] from comment #5)
> Comment on attachment 654231 [details] [diff] [review]
> rip out old* references from android repack mozharness scripts
> 
> I think this would be cleaner if we ripped out the create snippets and
> upload snippets actions from sign_android.py entirely, rather than have them
> there but crippled.

I'm not sure that only having partial snippets is crippling it, but I'm happy to defer to you on this. I'll take a stab at removing them entirely.

> That means removing them from all_actions and removing the create_snippets()
> and upload_snippets() methods from sign_android.py.

Thanks for the guidance!
(Assignee)

Comment 7

5 years ago
Created attachment 654587 [details] [diff] [review]
rip out snippet support completely

I ripped out the self.fatal() when buildid isn't set, because the comment seemed to say that it's not fatal when we're not doing snippets.

Passes tests, I'm not sure how else to test it.
Attachment #654587 - Flags: review?(aki)
(Assignee)

Updated

5 years ago
Blocks: 772038

Comment 8

5 years ago
Comment on attachment 654587 [details] [diff] [review]
rip out snippet support completely

I think we can rip out query_buildid() completely too, as nothing's calling it anymore.  This looks good, thanks Ben!
Attachment #654587 - Flags: review?(aki) → review+
(Assignee)

Updated

5 years ago
Attachment #654231 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #654262 - Flags: checked-in+
(Assignee)

Comment 9

5 years ago
Comment on attachment 654587 [details] [diff] [review]
rip out snippet support completely

> I think we can rip out query_buildid() completely too, as nothing's calling
> it anymore.  This looks good, thanks Ben!

I did this in the landed patch.
Attachment #654587 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.