784712 - [devhub] put devhub behind feature flag?

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Fred Wenzel [:wenzel]]

Let's put the devhub behind a feature flag and switch it off for this week's release. The devhub is neither design nor content complete so we can't push it live like this yet.

cvan, can you help Jen with this?

Comment 1

[Christopher Van Wiemeersch [:cvan]]

If we put this behind a feature flag, developers have even less content to learn how to submit an app. I'm not okay with doing this.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

If you want to revert Jen's changes and put them behind a flag, okay that's reasonable. I will say that it's not a trivial change and will probably take Jen or I at least two days to put behind a flag. The safest thing to do is revert the commits today and then merge them to master when they're ready. If you want to put it on a separate branch or put the code behind a flag later, that's fine.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #2)
> If you want to revert Jen's changes and put them behind a flag, okay that's
> reasonable. I will say that it's not a trivial change and will probably take
> Jen or I

Jen or me, silly!

Comment 4

[Fred Wenzel [:wenzel]]

I don't want to put anything behind a flag, but we can't ship half a site. If we're pushing tomorrow, then we need to make sure the devhub isn't half broken. Open to different solutions to that problem -- krupa suggested the feature flag but we're not dead-set on that :)

Comment 5

[Fred Wenzel [:wenzel]]

Oh so this has dropped a lot lower in urgency if there won't be a push tomorrow. We most likely don't need this for next week.

Comment 6

[Fred Wenzel [:wenzel]]

No need for a feature flag, apparently there won't be a full release today. Next week, we'll release the devhub. If any part of it won't make it, we'll take the code out, not put it behind a feature flag.