784746 - Contacts API: optimize debug statements

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Currently we create lots of garbage because we use 

let DEBUG = 0;
if (DEBUG)
  debug = function (s) { dump("-*- ContactManager: " + s + "\n"); }
else
  debug = function (s) {}

debug(...)

I want to change it to 
if (DEBUG) debug()

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Does the perf needle move with this patch?

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 654314 [details] [diff] [review]
patch

Review of attachment 654314 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me!

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 654314 [details] [diff] [review]
patch

Review of attachment 654314 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/ContactManager.js
@@ +4,5 @@
>  
>  "use strict";
>  
> +const DEBUG = false;
> +debug = function (s) { dump("-*- ContactManager: " + s + "\n"); }

Missing variable definition for `debug`. Either

  let debug = ...

or

  function debug(...) ...

(I suggest the latter.)

Comment 6

[Gregor Wagner [:gwagner]]

Fixed the variable definition.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f340329e85b

Comment 7

[Andreas Gal :gal]

What about comment 3?

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to Andreas Gal :gal from comment #7)
> What about comment 3?

500 contacts take now 1.5 sec with the UI Test -> Get all contacts.
So from 9sec to 1.5sec.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3f340329e85b