Closed Bug 784748 Opened 7 years ago Closed 7 years ago

Talkback speaks TextSwitcher's contents when tabs ImageButton is already properly labelled

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 17

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Keywords: access)

Attachments

(1 file)

STR:
1. Swipe navigate the browser toolbar, until you reach refresh button.
2. Swipe right again and hear "1 tab button" (or "n tabs button").
3. Swipe again and hear "1" (or however many tabs are open).

Expected result: The last swipe above (#3) should move on to the next button, usually the menu button.
Keywords: access
OS: Linux → Android
Hardware: x86_64 → ARM
Comment on attachment 654312 [details] [diff] [review]
Make TextSwitcher and its contents invisible to accessibility.

Review of attachment 654312 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. What would happen when we just pass a null instead of a listener? Would it use a default?
Attachment #654312 - Flags: review?(sriram) → review+
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Comment on attachment 654312 [details] [diff] [review]
> Make TextSwitcher and its contents invisible to accessibility.
> 
> Review of attachment 654312 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good to me. What would happen when we just pass a null instead of
> a listener? Would it use a default?

Thanks!

Pass a null where? I am not sure what you mean by "listener".
https://hg.mozilla.org/mozilla-central/rev/e764ad3c6c68
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.