784748 - Talkback speaks TextSwitcher's contents when tabs ImageButton is already properly labelled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

STR:
1. Swipe navigate the browser toolbar, until you reach refresh button.
2. Swipe right again and hear "1 tab button" (or "n tabs button").
3. Swipe again and hear "1" (or however many tabs are open).

Expected result: The last swipe above (#3) should move on to the next button, usually the menu button.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Make TextSwitcher and its contents invisible to accessibility.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 654312 [details] [diff] [review]
Make TextSwitcher and its contents invisible to accessibility.

Review of attachment 654312 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. What would happen when we just pass a null instead of a listener? Would it use a default?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Comment on attachment 654312 [details] [diff] [review]
> Make TextSwitcher and its contents invisible to accessibility.
> 
> Review of attachment 654312 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good to me. What would happen when we just pass a null instead of
> a listener? Would it use a default?

Thanks!

Pass a null where? I am not sure what you mean by "listener".

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e764ad3c6c68

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e764ad3c6c68