Closed Bug 784758 Opened 12 years ago Closed 12 years ago

Kuma: Editor - When you hit enter in the rev comment field and save, clear the rev comment field

Categories

(developer.mozilla.org Graveyard :: Editing, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sheppy, Unassigned)

Details

Right now, hitting enter in the revision comment field performs a save-and-keep-editing. This is okay (although it's debatable that this might be better as a save-and-close, I'm not sure). However, it doesn't clear out the revision comment field, and should, since odds are your next save will not want an identical revision note.
I wonder if we should remove the Enter action altogether. I wonder if any two users would expect the same thing to happen when doing that.
Hitting enter in that field on MindTouch saved and exited the editor (which was a behavior I actually requested). That said, I wouldn't complain extensively if it were removed. But I like it personally. Saves a bit of time.
Fair enough. I think it makes sense to keep it then. I do wonder if many people hit Enter expecting it to set a tag (like the comma does now), but we can look into that later.
Nevermind, this has nothing to do with tags.
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/83df8a0a3f0b6436c5f1cc777f0aac120fd39aec
fix bug 784758 - SAK button clears comment field upon save

https://github.com/mozilla/kuma/commit/55d30e2c7997095cb7fba56da9bcaa0873143b7c
Merge pull request #539 from darkwing/sace-comment-clear-784758

fix bug 784758 - SAK button clears comment field upon save
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified fixed https://developer.allizom.org/en-US/docs/HTML$edit
Status: RESOLVED → VERIFIED
Version: Kuma → unspecified
Component: Docs Platform → Editing
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.