784765 - IonMonkey: Inline actual string compare

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

At the moment we only handle some cases, but we never actually compare the chars, even for linear strings.

Comment 1

[Tom S [:evilpie]]

Memo:
Just calling memcmp doesn't seem to improve anything. And implementing this inline requires quite a lot of registers.

Comment 2

[Tom S [:evilpie]]

Attachment: v1 only compare string.length

Just comparing the string length is an easy win. We should do this in the meantime. https://tbpl.mozilla.org/?tree=Try&rev=1b867253e1f9

Comment 3

[Tom S [:evilpie]]

Attachment: v2 now with moar compiling code!

https://tbpl.mozilla.org/?tree=Try&rev=17af51d4723b

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 668779 [details] [diff] [review]
v2 now with moar compiling code!

Review of attachment 668779 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, great idea!

Comment 5

[Tom S [:evilpie]]

Awesome.
http://hg.mozilla.org/integration/mozilla-inbound/rev/5a3283cb92b8

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5a3283cb92b8