IonMonkey: Inline actual string compare

RESOLVED FIXED in mozilla18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla18
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:t])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
At the moment we only handle some cases, but we never actually compare the chars, even for linear strings.
Whiteboard: [ion:t]
(Assignee)

Comment 1

5 years ago
Memo:
Just calling memcmp doesn't seem to improve anything. And implementing this inline requires quite a lot of registers.
(Assignee)

Comment 2

5 years ago
Created attachment 668568 [details] [diff] [review]
v1 only compare string.length

Just comparing the string length is an easy win. We should do this in the meantime. https://tbpl.mozilla.org/?tree=Try&rev=1b867253e1f9
(Assignee)

Comment 3

5 years ago
Created attachment 668779 [details] [diff] [review]
v2 now with moar compiling code!

https://tbpl.mozilla.org/?tree=Try&rev=17af51d4723b
Attachment #668568 - Attachment is obsolete: true
Attachment #668779 - Flags: review?(jdemooij)
Comment on attachment 668779 [details] [diff] [review]
v2 now with moar compiling code!

Review of attachment 668779 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, great idea!
Attachment #668779 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/5a3283cb92b8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.