78479 - frequent hang on quit after long use

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[hirata masakazu]

2001050108 Mtrunk
I noticed that it took a lot longer than before for Mozilla 0430 build to finish
quitting job.
Now with 0501 build, it is a complete hang. You wait for longer than 15 min and,
still there is nothing you can do but to force quit.
This may be related to bug 66730, but I never saw it to occur in builds prior to
0430 build.
Memory and Disk Cache are set to 0.
History.dat, Bookmarks.html, Panacea.dat, and history.mab files are not bloated.

Comment 1

[hirata masakazu]

Attachment: stack trace upon force quit at hang

Comment 2

[Edward Kandrot]

Looks like a cache problem, since that is what is on the stack.

Comment 3

[Edward Kandrot]

Looks like a cache problem, since that is what is on the stack.

Comment 4

[gordon]

Did this happen just once, or everytime?  I have been unable to reproduce this 
with my build from 2001/05/02.

Comment 5

[Koike Kazuhiko]

A Japanese user reported a similar problem.

(1) Open Preferences dialog, select Advanced - Cache tab and
check "Automatically".

(2) Mozilla crashed on exit after navigating many web pages.

(3) Disk cache becomes unavailable. If you restart Mozilla and
see "about:cache", you can see memory cache only.

He saw this problem with 2001-05-01-04/Win2k and 2001-05-02-04/Win2k.

http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=877

Comment 6

[lchiang]

Need help reproducing this bug.  tever or ben - can you help reproduce this with
cache set to 0 as the user has?

Comment 7

[Tom Everingham]

hmmm, I loaded up the 2001050108 Mtrunk mozilla build on my OS9 box, set disk 
and mem cache to 0, and ran it for well over an hour with a few exits.  I'm not 
seeing this yet.  Letting it run overnight. 

Comment 8

[hirata masakazu]

I think it involved downloading a large file or something. After several force
quits, Mozilla started to ignore the Mail/News settings (though still present in
prefs.js) and launched Account wizard. Since it happened, I have not seen this
hang on exit yet. Has anything changed in Preferences around 0430-0502?

Comment 9

[gordon]

I think I know what's happening with the original stack trace.  I should have a 
patch later today to fix it.

Comment 10

[gordon]

Here's the patch:

Index: mozilla/netwerk/cache/src/nsCacheService.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/cache/src/nsCacheService.cpp,v
retrieving revision 1.46
diff -u -2 -r1.46 nsCacheService.cpp
--- nsCacheService.cpp	2001/05/03 02:35:19	1.46
+++ nsCacheService.cpp	2001/05/07 17:54:07
@@ -1112,4 +1112,6 @@
     gService->ClearPendingRequests(entry);
     entry->DetachDescriptors();
+    
+    entry->MarkInactive();  // so we don't call Remove() while we're enumerating
     gService->DeactivateEntry(entry);
     

Comment 11

[Darin Fisher]

sr=darin

Comment 12

[gordon]

Fix checked in.

Comment 13

[Bradley Baetz (:bbaetz)]

lxr confirms that the patch was checked in, and there are no reproducable steps,
so marking VERIFIED.