784790 - GCLI cookie command should use internal Cookie API rather than document.cookie

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Kevin Dangoor]

STR:
1. go to http://www.mozilla.org/
2. cookie list (see WT_FPC cookie and possibly others)
3. cookie remove WT_FPC
4. cookie list

Expected: no WT_FPC cookie listed
Result: WT_FPC cookie lives on (at least in the list!)

Comment 1

[Joe Walker [:jwalker]]

This is half expected, because cookies are like that. Really we should be using the official cookie API.

Comment 2

[Joe Walker [:jwalker]]

There's lots of potential to be smarter if we're using the official API:

>> cookie list --on-domain google.com

(lists cookies from google.com whatever page you're currently on)

>> cookie edit WT_FPC some-value

(Alters the value of a cookie, maybe also set flags, e.g. HTTP_Only)

Comment 3

[Joe Walker [:jwalker]]

We could make use of a date type (see bug 773271) with the expires field.

Comment 4

[Mark Goodwin [:mgoodwin]]

Attachment: First kick at using nsICookieManager2 for cookie operations

I know Joe's hacking on the version of my code I gave him, I wanted somewhere to put my patch in the meantime.

Comment 5

[Joe Walker [:jwalker]]

Attachment: v2 (cookie list output update)

Added updates to 'cookie list' output.

Comment 6

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Rebased plus added test

Comment 8

[Joe Walker [:jwalker]]

Attachment: v3

Comment 9

[Joe Walker [:jwalker]]

See https://github.com/joewalker/gcli/commit/faa3507ac5b654338b6dae77e98d26303224f5b5 for detail on changes in GCLI.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 728368 [details] [diff] [review]
v3

Review of attachment 728368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 11

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=d5cdec6efff9
https://hg.mozilla.org/integration/fx-team/rev/d5cdec6efff9

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d5cdec6efff9