Closed Bug 784849 Opened 12 years ago Closed 12 years ago

Merge different states of back button into a single sprite image

Categories

(Firefox for Metro Graveyard :: General, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwilde, Assigned: fryn)

References

Details

(Whiteboard: [completed-elm])

Attachments

(1 file)

It currently flickers when you move to a new page because of the time taken to load the "active" version from disk.
This affects Metro Firefox (on Elm) only. Sorry for the noise.
OS: Windows 8 → Windows 8 Metro
Attached patch patchSplinter Review
I do not experience the flicker that you noted, but as we will be adding more states to these buttons, we should probably be using sprites here, so here is a patch. forward-default.png changed, because I cut down its file size via pngcrush.
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Attachment #658874 - Flags: review?(mbrubeck)
Attachment #658874 - Flags: review?(mbrubeck) → review+
Pushed a followup fix for one back button that we missed: https://hg.mozilla.org/projects/elm/rev/953cea089a34
Pushed a second followup fix for the panel close button disabled state: https://hg.mozilla.org/projects/elm/rev/af06d58e064a
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: