Closed
Bug 784873
Opened 13 years ago
Closed 13 years ago
Improve ParallelArray testsuite code
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
19.12 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Currently I'm testing equality on ParallelArray objects by calling .toString(), which is unfortunate.
Assignee | ||
Updated•13 years ago
|
Assignee: general → shu
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite+
Assignee | ||
Comment 1•13 years ago
|
||
Add and use |assertEqParallelArray| helper to compare PAs directly instead of using |toString|.
Assignee | ||
Updated•13 years ago
|
Attachment #654490 -
Flags: review?(dvander)
![]() |
||
Updated•13 years ago
|
Attachment #654490 -
Flags: review?(dvander) → review-
Comment on attachment 654490 [details] [diff] [review]
patch
Review of attachment 654490 [details] [diff] [review]:
-----------------------------------------------------------------
Whoops, I'm sorry! That was a total misclick on my part.
Attachment #654490 -
Flags: review- → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•