The default bug view has changed. See this FAQ.

Improve ParallelArray testsuite code

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla17
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently I'm testing equality on ParallelArray objects by calling .toString(), which is unfortunate.
(Assignee)

Updated

5 years ago
Assignee: general → shu
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
(Assignee)

Comment 1

5 years ago
Created attachment 654490 [details] [diff] [review]
patch

Add and use |assertEqParallelArray| helper to compare PAs directly instead of using |toString|.
(Assignee)

Updated

5 years ago
Attachment #654490 - Flags: review?(dvander)
Attachment #654490 - Flags: review?(dvander) → review-
Comment on attachment 654490 [details] [diff] [review]
patch

Review of attachment 654490 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops, I'm sorry! That was a total misclick on my part.
Attachment #654490 - Flags: review- → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/0eece65be2df
https://hg.mozilla.org/mozilla-central/rev/0eece65be2df
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.