Last Comment Bug 784873 - Improve ParallelArray testsuite code
: Improve ParallelArray testsuite code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla17
Assigned To: Shu-yu Guo [:shu]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 17:09 PDT by Shu-yu Guo [:shu]
Modified: 2012-08-26 19:25 PDT (History)
1 user (show)
shu: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (19.12 KB, patch)
2012-08-22 19:04 PDT, Shu-yu Guo [:shu]
dvander: review+
Details | Diff | Splinter Review

Description Shu-yu Guo [:shu] 2012-08-22 17:09:33 PDT
Currently I'm testing equality on ParallelArray objects by calling .toString(), which is unfortunate.
Comment 1 Shu-yu Guo [:shu] 2012-08-22 19:04:45 PDT
Created attachment 654490 [details] [diff] [review]
patch

Add and use |assertEqParallelArray| helper to compare PAs directly instead of using |toString|.
Comment 2 David Anderson [:dvander] 2012-08-23 18:14:18 PDT
Comment on attachment 654490 [details] [diff] [review]
patch

Review of attachment 654490 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops, I'm sorry! That was a total misclick on my part.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-26 19:25:45 PDT
https://hg.mozilla.org/mozilla-central/rev/0eece65be2df

Note You need to log in before you can comment on or make changes to this bug.