put NPOTB tools/utilities in js/src/devtools

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

mv
13.02 KB, patch
sfink
: review+
Details | Diff | Splinter Review
Posted patch mv (obsolete) — Splinter Review
I talked about this with sfink a long time ago: it would be nice to keep the not-part-of-the-build random helper files in a subdirectory of js/src.  (This is part of the general modularization plan (https://wiki.mozilla.org/JS_engine_modularization) which wants to generally move things out of js/src.)

/moz/mi/js/src $ ls -1 devtools
ETWProvider.man
gc
gnuplot
javascript-trace.d
jint
sharkctl.cpp
sharkctl.h
vprof
Attachment #654481 - Flags: review?(sphink)
Comment on attachment 654481 [details] [diff] [review]
mv

Sorry for the review delay. This patch will break --enable-dtrace and --enable-etw, at least, because it doesn't update the Makefile.in targets. I can fix up --enable-dtrace easily enough. It'll take me a little longer to get to --enable-etw; it would be fine to land without doing that, though.
Oh yes, sorry about that, I'll post a new patch with dtrace fixed.
Posted patch mvSplinter Review
Attachment #654481 - Attachment is obsolete: true
Attachment #654481 - Flags: review?(sphink)
Attachment #655227 - Flags: review?
Attachment #655227 - Flags: review? → review?(sphink)
Comment on attachment 655227 [details] [diff] [review]
mv

Review of attachment 655227 [details] [diff] [review]:
-----------------------------------------------------------------

I tried out dtrace and it still works. Good enough for me.
Attachment #655227 - Flags: review?(sphink) → review+
Followup fix for OS X:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b3af36ea9cf

(I thought I had try'd this on all platforms.)
https://hg.mozilla.org/mozilla-central/rev/f24546b76f3e
https://hg.mozilla.org/mozilla-central/rev/7b3af36ea9cf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 655227 [details] [diff] [review]
mv

Review of attachment 655227 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -130,5 @@
>  		TestingFunctions.cpp \
>  		LifoAlloc.cpp \
>  		Eval.cpp \
>  		MapObject.cpp \
> -		MemoryMetrics.cpp \

Why?
(In reply to :Ms2ger from comment #8)

Because every other .cpp in js/src starts with 'js', it looked out of place.
> Because every other .cpp in js/src starts with 'js', it looked out of place.

js/src/public/MemoryMetrics.h now looks out of place...
Not locally:

/moz/mi/js $ ls public/
HashTable.h  LegacyIntTypes.h  MemoryMetrics.h  TemplateLib.h  Utility.h  Vector.h

To fix the difference between js/src and all the new dirs, we could mass-rename jsfoo.h to Foo.h...
You need to log in before you can comment on or make changes to this bug.