Last Comment Bug 784897 - Remove nsITCPSocket constants
: Remove nsITCPSocket constants
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla18
Assigned To: Donovan Preston [:fzzzy]
:
Mentors:
Depends on: 733573
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 18:27 PDT by Jonas Sicking (:sicking)
Modified: 2013-04-04 13:53 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove the constants (1.96 KB, patch)
2012-08-27 20:49 PDT, Donovan Preston [:fzzzy]
jonas: review+
Details | Diff | Review

Description Jonas Sicking (:sicking) 2012-08-22 18:27:08 PDT
Since JS isn't compiled, it doesn't actually buy developers anything. I.e.

mySocket.readyState == TCPSocket.CONTECTING

behaves the same as

mySocket.readyState == "conecting"
Comment 1 Donovan Preston [:fzzzy] 2012-08-27 20:49:12 PDT
Created attachment 655870 [details] [diff] [review]
Remove the constants
Comment 2 Donovan Preston [:fzzzy] 2012-08-29 11:08:49 PDT
Comment on attachment 655870 [details] [diff] [review]
Remove the constants

Jonas, if you are not the right guy to review this, can you assign it to someone who can? Thanks!
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-09-04 19:25:03 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954

Thanks for the patch, Donovan! One request - to make life easier for those checking in on your behalf in the future, please be sure to configure your hg to include all the necessary commit information in the patches per the guidelines below. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Comment 4 Donovan Preston [:fzzzy] 2012-09-05 11:50:31 PDT
(In reply to Ryan VanderMeulen from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954
> 
> Thanks for the patch, Donovan! One request - to make life easier for those
> checking in on your behalf in the future, please be sure to configure your
> hg to include all the necessary commit information in the patches per the
> guidelines below. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

Ok, done. Thanks for the tip!
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-09-05 19:44:01 PDT
https://hg.mozilla.org/mozilla-central/rev/839b06aaa954

Note You need to log in before you can comment on or make changes to this bug.