The default bug view has changed. See this FAQ.

Remove nsITCPSocket constants

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sicking, Assigned: fzzzy)

Tracking

Trunk
mozilla18
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Since JS isn't compiled, it doesn't actually buy developers anything. I.e.

mySocket.readyState == TCPSocket.CONTECTING

behaves the same as

mySocket.readyState == "conecting"
(Assignee)

Comment 1

5 years ago
Created attachment 655870 [details] [diff] [review]
Remove the constants
Assignee: nobody → dpreston
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Comment on attachment 655870 [details] [diff] [review]
Remove the constants

Jonas, if you are not the right guy to review this, can you assign it to someone who can? Thanks!
Attachment #655870 - Flags: review?(jonas)
Attachment #655870 - Flags: review?(jonas) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954

Thanks for the patch, Donovan! One request - to make life easier for those checking in on your behalf in the future, please be sure to configure your hg to include all the necessary commit information in the patches per the guidelines below. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
(In reply to Ryan VanderMeulen from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954
> 
> Thanks for the patch, Donovan! One request - to make life easier for those
> checking in on your behalf in the future, please be sure to configure your
> hg to include all the necessary commit information in the patches per the
> guidelines below. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

Ok, done. Thanks for the tip!
https://hg.mozilla.org/mozilla-central/rev/839b06aaa954
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.