Closed Bug 784897 Opened 8 years ago Closed 8 years ago

Remove nsITCPSocket constants

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: sicking, Assigned: fzzzy)

References

Details

Attachments

(1 file)

Since JS isn't compiled, it doesn't actually buy developers anything. I.e.

mySocket.readyState == TCPSocket.CONTECTING

behaves the same as

mySocket.readyState == "conecting"
Assignee: nobody → dpreston
Status: NEW → ASSIGNED
Comment on attachment 655870 [details] [diff] [review]
Remove the constants

Jonas, if you are not the right guy to review this, can you assign it to someone who can? Thanks!
Attachment #655870 - Flags: review?(jonas)
Attachment #655870 - Flags: review?(jonas) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954

Thanks for the patch, Donovan! One request - to make life easier for those checking in on your behalf in the future, please be sure to configure your hg to include all the necessary commit information in the patches per the guidelines below. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
(In reply to Ryan VanderMeulen from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954
> 
> Thanks for the patch, Donovan! One request - to make life easier for those
> checking in on your behalf in the future, please be sure to configure your
> hg to include all the necessary commit information in the patches per the
> guidelines below. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

Ok, done. Thanks for the tip!
https://hg.mozilla.org/mozilla-central/rev/839b06aaa954
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.