784897 - Remove nsITCPSocket constants

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Since JS isn't compiled, it doesn't actually buy developers anything. I.e.

mySocket.readyState == TCPSocket.CONTECTING

behaves the same as

mySocket.readyState == "conecting"

Comment 1

[Donovan Preston [:fzzzy]]

Attachment: Remove the constants

Comment 2

[Donovan Preston [:fzzzy]]

Comment on attachment 655870 [details] [diff] [review]
Remove the constants

Jonas, if you are not the right guy to review this, can you assign it to someone who can? Thanks!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954

Thanks for the patch, Donovan! One request - to make life easier for those checking in on your behalf in the future, please be sure to configure your hg to include all the necessary commit information in the patches per the guidelines below. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 4

[Donovan Preston [:fzzzy]]

(In reply to Ryan VanderMeulen from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/839b06aaa954
> 
> Thanks for the patch, Donovan! One request - to make life easier for those
> checking in on your behalf in the future, please be sure to configure your
> hg to include all the necessary commit information in the patches per the
> guidelines below. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

Ok, done. Thanks for the tip!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/839b06aaa954