Package TCPSocket.{js|manifest) to fix: TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true

VERIFIED FIXED in seamonkey2.15

Status

SeaMonkey
Build Config
P2
major
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.15
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.14 fixed)

Details

(Whiteboard: [perma-orange])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1345674832.1345677240.26708.gz

TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true
TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true
TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: navigator.mozTCPSocket is

Caused by Bug 733573 - Expose a client TCP socket API to web applications

Also see TB http://hg.mozilla.org/comm-central/rev/04b378637986
Add TCPSocket.js/.manifest to packaged files to fix xpcshell bustage after bug 733573 landed in m-c. r+a=bustage-fix
(Assignee)

Comment 1

5 years ago
Created attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #654566 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

5 years ago
Blocks: 452942
Severity: normal → major
Priority: -- → P2
Whiteboard: [perma-orange]
Target Milestone: --- → seamonkey2.14
Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

Review of attachment 654566 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this
Attachment #654566 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

https://hg.mozilla.org/comm-central/rev/1e74e0c88d8e


[Approval Request Comment]
No risk, I was just too slow to check this patch in.
Attachment #654566 - Attachment description: (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in → (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3]
Attachment #654566 - Flags: approval-comm-aurora?
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-seamonkey2.14: --- → affected
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: seamonkey2.14 → seamonkey2.15
(Assignee)

Comment 4

5 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1346782230.1346783362.19848.gz
WINNT 5.2 comm-central-trunk debug test mochitests-2/5 on 2012/09/04 11:10:30

V.Fixed. (m-2 is green again ;-))
Status: RESOLVED → VERIFIED
Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

Review of attachment 654566 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this
Attachment #654566 - Flags: approval-comm-aurora? → approval-comm-aurora+
http://hg.mozilla.org/releases/comm-aurora/rev/8d75771f48b3
status-seamonkey2.14: affected → fixed
You need to log in before you can comment on or make changes to this bug.