784922 - Package TCPSocket.{js|manifest) to fix: TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[Philip Chee]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1345674832.1345677240.26708.gz

TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true
TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true
TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: navigator.mozTCPSocket is

Caused by Bug 733573 - Expose a client TCP socket API to web applications

Also see TB http://hg.mozilla.org/comm-central/rev/04b378637986
Add TCPSocket.js/.manifest to packaged files to fix xpcshell bustage after bug 733573 landed in m-c. r+a=bustage-fix

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3]

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

Review of attachment 654566 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

https://hg.mozilla.org/comm-central/rev/1e74e0c88d8e


[Approval Request Comment]
No risk, I was just too slow to check this patch in.

Comment 4

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1346782230.1346783362.19848.gz
WINNT 5.2 comm-central-trunk debug test mochitests-2/5 on 2012/09/04 11:10:30

V.Fixed. (m-2 is green again ;-))

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 654566 [details] [diff] [review]
(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in
[Checked in: Comment 3]

Review of attachment 654566 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-aurora/rev/8d75771f48b3