784925 - Readback w/OGL layers broken on Mac

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

With webgl reftests, I was seeing failures on Mac when forcing fallback to readback, (but still OGL layers).

Running a build locally, we're getting FB binding misprediction asserts. However, it looks like the problem is actually that we didn't MakeCurrent for the Readback path in OGL Layers.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch with some misc. cleanup

I moved fGetIntegerv() up to near fBindFramebuffer, so it's more clear that we're hooking both of them similarly.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: reformed patch with cleanup

Comment 3

[Kelsey Gilbert [:jgilbert]]

This is a blocker for reftests to fix these issues:
https://tbpl.mozilla.org/?tree=Try&noignore=1&rev=2227fd734659

Comment 4

[Kelsey Gilbert [:jgilbert]]

With this patch:
https://tbpl.mozilla.org/?tree=Try&noignore=1&rev=08d1e14faab1

We go from roughly 20 failures per mac platform to 17. It looks like the '20' number might be somewhat random, since there doesn't seem to be much in common between the tests which were failing but are now fixed, other than that all readback w/alpha paths work after applying this patch. Note also that (with this patch) we no longer crash on debug mac builds (on readback) with FB shadow misprediction errors.

Fixing readback w/o alpha is done by the patch to bug 735932.

With this patch, Mac 10.8 passes the readback tests failing on other Mac versions.

Comment 6

[Kelsey Gilbert [:jgilbert]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=fb8074886fb0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb8074886fb0

Comment 8

[Kelsey Gilbert [:jgilbert]]

With backporting webgl reftests to Aurora 17, we hit this problem again. Since we added the pref for this in 17, we should fix it so it works. This does not affect 16.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

No need to track this, but please go ahead and nominate the patch for uplift to Aurora.