<audio>.buffered changes everytime <audio>.currentTime changes (inc. within buffered range)

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gravgun, Assigned: cpearce)

Tracking

({regression, testcase})

15 Branch
mozilla17
x86
Windows 7
regression, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120814224555

Steps to reproduce:

I was creating a canvas wrapper for an audio element, and I use mouse to rotate a knob. I noticed the buffer indicator was blinking when changing currentTime, even when the audio have been fully buffered.


Actual results:

The audio.buffered property empties itself then comes back to correct buffering information when audio.currentTime is changed.


Expected results:

The audio.buffered property should not change when the requested portion of audio have already been buffered.
(Reporter)

Comment 1

5 years ago
Created attachment 654521 [details]
Example case of the bug.
(Reporter)

Updated

5 years ago
Component: Untriaged → General

Updated

5 years ago
Attachment #654521 - Attachment mime type: text/plain → text/html

Comment 2

5 years ago
Did you observe this behavior in Firefox 14?
Confirmed in 15 Beta and Trunk. It' WFM in 14 Release.
Component: General → General
Keywords: regression, regressionwindow-wanted, testcase
Product: Firefox → Core
Last good nightly: 2012-05-27
First bad nightly: 2012-05-28

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=133aa3a2ef0a&tochange=79262a88881d
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to Paul Silaghi [QA] from comment #4)
Got the same Range over here, too.
Maybe regressed by Bug 755533?
Component: General → Video/Audio

Comment 6

5 years ago
Same range here with mozreg.
Blocks: 755533
Keywords: regressionwindow-wanted
(Assignee)

Comment 7

5 years ago
Ah, so in nsHTMLMediaElement::GetBuffered() only returns buffered ranges if we in readyState >= HAVE_CURRENT_DATA, and in bug 755533 we changed nsHTMLMediaElement::SeekStarted() to set the readyState to HAVE_METADATA...
I think we should change the former condition...
(Assignee)

Comment 9

5 years ago
Created attachment 655513 [details] [diff] [review]
Patch

Simple fix: allow HTMLMediaElement.buffered to return results when readyState > HAVE_NOTHING.
Assignee: nobody → cpearce
Attachment #655513 - Flags: review?(roc)
Attachment #655513 - Flags: review?(roc) → review+
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3fde74539de
https://hg.mozilla.org/mozilla-central/rev/b3fde74539de
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.