784932 - <audio>.buffered changes everytime <audio>.currentTime changes (inc. within buffered range)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[gravgun]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120814224555

Steps to reproduce:

I was creating a canvas wrapper for an audio element, and I use mouse to rotate a knob. I noticed the buffer indicator was blinking when changing currentTime, even when the audio have been fully buffered.


Actual results:

The audio.buffered property empties itself then comes back to correct buffering information when audio.currentTime is changed.


Expected results:

The audio.buffered property should not change when the requested portion of audio have already been buffered.

Comment 1

[gravgun]

Attachment: Example case of the bug.

Comment 2

[Loic]

Did you observe this behavior in Firefox 14?

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirmed in 15 Beta and Trunk. It' WFM in 14 Release.

Comment 4

[Paul Silaghi, QA [:pauly]]

Last good nightly: 2012-05-27
First bad nightly: 2012-05-28

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=133aa3a2ef0a&tochange=79262a88881d

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to Paul Silaghi [QA] from comment #4)
Got the same Range over here, too.
Maybe regressed by Bug 755533?

Comment 6

[Loic]

Same range here with mozreg.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Ah, so in nsHTMLMediaElement::GetBuffered() only returns buffered ranges if we in readyState >= HAVE_CURRENT_DATA, and in bug 755533 we changed nsHTMLMediaElement::SeekStarted() to set the readyState to HAVE_METADATA...

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should change the former condition...

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Simple fix: allow HTMLMediaElement.buffered to return results when readyState > HAVE_NOTHING.

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3fde74539de

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3fde74539de