78505 - Hidden plugins cause page flicker on Mac

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P5)

Description

[Peter Lubczynski]

Turning off double buffering has caused pages to flicker on Mac that contain a 
plugin. If the plugin is of type "hidden", there is no reason to turn off double 
buffering. This will enchance the users experience for hidden plugins on the 
Mac.

Sean, do you have a link to an example?

Comment 1

[sean echevarria]

At http://www.beatnik.com/emix/science1999nc/standalone-launch.html click 
the "Click to launch" link.  Then after once a window appears with a button 
labeled "let's Jam!", press it.  I've got a feeling that this is actually 
pretty good now (but it might be due to hacks I've put in place in my mac 
build).

Comment 2

[Peter Lubczynski]

Attachment: patch to double buffer if hidden plugin on Mac

Comment 3

[Peter Lubczynski]

Okay, here's a quick patch. 

Sean, this should fix it for all Gecko enbedding browsers.

Comment 4

[sean echevarria]

deja vu!  That's my patch from bug 62891.  Check the comments (including your 
own!) made on Dec 22.

Comment 5

[Peter Lubczynski]

Since we don't check style visibility anyway in object frame, this will at least 
make the users' experience of hidden plugins initially better untill such time 
that bug 62891 can be truely fixed. Sean, can I get your r= if this works for 
you?

Comment 6

[sean echevarria]

Attachment: html testcase for dynamic hiding of plugins

Comment 7

[sean echevarria]

I applied the patch and did some testing.  It does not appear to affect dynamic 
hiding of plugins (see attached testcase).  However it doesn't appear to have 
the same results that it used to.  The emix testcase 
(http://www.beatnik.com/emix/science1999nc/standalone-launch.html) is horrible 
when clicking the mix track keybuttons with the mouse - the mix window goes 
spastic with each click.  Using the keyboard is pretty good with or without the 
patch.  I don't think the patch has a visible benefit anymore (maybe due to the 
new view manager?).

Comment 8

[Peter Lubczynski]

There is a lot more work to be done with hidden plugins....moving off 9.1 radar.

Comment 9

[Peter Lubczynski]

I won't get to this today--->mozilla 0.9.4

Comment 10

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 11

[rubydoo123]

this was fixed long ago, marking as such

Comment 12

[shrirang khanzode]

yep,v