The default bug view has changed. See this FAQ.

[AccessFu] Work around timestamp issue in emulated touch events.

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 654615 [details] [diff] [review]
Work around touch emulation timestamp issue.
Attachment #654615 - Flags: review?(dbolter)
Comment on attachment 654615 [details] [diff] [review]
Work around touch emulation timestamp issue.

Review of attachment 654615 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with considerations below:

::: accessible/src/jsat/TouchAdapter.jsm
@@ +87,5 @@
>      let touches = aEvent.changedTouches;
> +    // XXX: Until bug 77992 is resolved, on desktop we get microseconds
> +    // instead of milliseconds.
> +    let timeStamp = (Utils.OS == 'Android') ? aEvent.timeStamp :
> +      new Date().getTime();

Date.now() is much faster than (new Date()).getTime();

Also, you could call timeStamp "time" or "now" if you wanted.
Attachment #654615 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d636babbf532

Thanks for the Date.now() tip..
Assignee: nobody → eitan
(In reply to Eitan Isaacson [:eeejay] from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d636babbf532
> 
> Thanks for the Date.now() tip..

I really shouldn't give dating tips.
https://hg.mozilla.org/mozilla-central/rev/d636babbf532
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.