785076 - [AccessFu] Work around timestamp issue in emulated touch events.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Work around touch emulation timestamp issue.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 654615 [details] [diff] [review]
Work around touch emulation timestamp issue.

Review of attachment 654615 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with considerations below:

::: accessible/src/jsat/TouchAdapter.jsm
@@ +87,5 @@
>      let touches = aEvent.changedTouches;
> +    // XXX: Until bug 77992 is resolved, on desktop we get microseconds
> +    // instead of milliseconds.
> +    let timeStamp = (Utils.OS == 'Android') ? aEvent.timeStamp :
> +      new Date().getTime();

Date.now() is much faster than (new Date()).getTime();

Also, you could call timeStamp "time" or "now" if you wanted.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d636babbf532

Thanks for the Date.now() tip..

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Eitan Isaacson [:eeejay] from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d636babbf532
> 
> Thanks for the Date.now() tip..

I really shouldn't give dating tips.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d636babbf532