785089 - "Assertion failure: pn_type < PNK_LIMIT,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

odeURIL:(function(){})

asserts js debug shell on m-c changeset 198ca6edd0ae without any CLI arguments at Assertion failure: pn_type < PNK_LIMIT,

Due to skipped revisions, the first bad revision could be any of:
changeset:   103113:d7568555261c
user:        Alex Crichton
date:        Sat Aug 18 21:33:20 2012 -0700
summary:     Bug 433529: Part 1 - Statically resolve names for anonymous functions. r=jimb

changeset:   103114:4ebcfba34c38
user:        Alex Crichton
date:        Sat Aug 18 21:37:09 2012 -0700
summary:     Bug 433529: Part 2 - Add a displayAtom to JSFunction to store resolved names. r=jimb

(setting bisect in JSBugMon to reconfirm this bisection result)

Comment 1

[Christian Holler (:decoder)]

JSBugMon: Bisection requested, result:
Due to skipped revisions, the first bad revision could be any of:
changeset:   103113:d7568555261c
user:        Alex Crichton
date:        Sat Aug 18 21:33:20 2012 -0700
summary:     Bug 433529: Part 1 - Statically resolve names for anonymous functions. r=jimb

changeset:   103114:4ebcfba34c38
user:        Alex Crichton
date:        Sat Aug 18 21:37:09 2012 -0700
summary:     Bug 433529: Part 2 - Add a displayAtom to JSFunction to store resolved names. r=jimb

Comment 2

[u443197]

Attachment: patch

This is mostly the extra additions you already had in bug 433529 Jim, although tweaked slightly to just skip PNK_COLON for labels because there won't be an assignment after that.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 654673 [details] [diff] [review]
patch

Review of attachment 654673 [details] [diff] [review]:
-----------------------------------------------------------------

Seems familiar, somehow. Thanks for the quick turnaround!

Comment 4

[u443197]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcbf82dee1db

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fcbf82dee1db

Comment 6

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929