Closed
Bug 785110
Opened 13 years ago
Closed 13 years ago
Signaling code - strtok and strtok_r should be replaced with safe equivalents.
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehugg, Assigned: ehugg)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
34.51 KB,
patch
|
jesup
:
feedback+
|
Details | Diff | Splinter Review |
Jesup recommends PL_strtok_r from plstr.h
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 654773 [details] [diff] [review]
Signaling code - strtok and strtok_r should be replaced with safe equivalents
strtok replaced with PL_strtok_r
Also I removed cpr_strtok, and the function "SipNtpUpdateClockFromCCM" whose job it was to set the time on the device from the REGISTER response.
Attachment #654773 -
Flags: feedback?(rjesup)
Attachment #654773 -
Flags: feedback?(ekr)
|
||
Updated•13 years ago
|
Attachment #654773 -
Flags: feedback?(rjesup) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ethanhugg
|
|
Assignee | |
Updated•13 years ago
|
Attachment #654773 -
Flags: feedback?(ekr)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 654773 [details] [diff] [review]
Signaling code - strtok and strtok_r should be replaced with safe equivalents
Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/06af3ad7c874
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•