Last Comment Bug 785161 - Stop uninstalling all installed apps in WebApps tests
: Stop uninstalling all installed apps in WebApps tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Apps (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mounir Lamouri (:mounir)
:
: [:fabrice] Fabrice Desré
Mentors:
Depends on:
Blocks: 777072
  Show dependency treegraph
 
Reported: 2012-08-23 11:26 PDT by Mounir Lamouri (:mounir)
Modified: 2012-08-23 14:09 PDT (History)
6 users (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (14.43 KB, patch)
2012-08-23 11:26 PDT, Mounir Lamouri (:mounir)
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2012-08-23 11:26:37 PDT
Created attachment 654712 [details] [diff] [review]
Patch

Fabrice, feel free to take that review from Justin ;)
Comment 1 Justin Lebar (not reading bugmail) 2012-08-23 11:36:07 PDT
Comment on attachment 654712 [details] [diff] [review]
Patch

Starting this review now.
Comment 2 Justin Lebar (not reading bugmail) 2012-08-23 13:41:31 PDT
Comment on attachment 654712 [details] [diff] [review]
Patch

>+  navigator.mozApps.getInstalled().onsuccess = function() {
>+    is(this.result.length, 0, "should get no installed app");
>+
>+    for (var i=0; i != this.result.length ; ++i) {
>+      var app = this.result[i];
>+      dump("\n\n" + app.manifestURL + "\n\n");
>+    }

This loop is the debugging code you said you removed, right?
Comment 3 Mounir Lamouri (:mounir) 2012-08-23 14:09:01 PDT
https://hg.mozilla.org/mozilla-central/rev/ebe6e3330f63

Note You need to log in before you can comment on or make changes to this bug.