785183 - Make sure re-review flagging reason is visible for apps in re-review queue.

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/reviewers/apps/review/remember-the-milkfrom the re-review queue
2. Scroll to the App History section

expected behavior:
The reason the app has been flagged for re-review is listed

observed behavior:
Many apps in the re-review queue are missing this information.

Comment 1

[Andrew Williamson [:eviljeff]]

The reason is there but it gets added to the approved 'version' so its on the third page.  

https://marketplace-dev.allizom.org/reviewers/apps/review/remember-the-milk?page=3#history

(Its got so many extra versions due to the over-active cron job that was running for a few weeks in May/June).

Solution would either be to fix the re-review entries so they always add to the latest version or to run something to delete the extra versions on the affected Apps.  My preference would be on the latter, if it could be done safely, though the former may be work needed for the packaged apps work anyway.

Comment 2

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #1)
> Solution would either be to fix the re-review entries so they always add to
> the latest version

FYI: This is already happening, with a minor correction... it's logging against the "current version", which is the latest version whose file status is PUBLIC. Since the other versions there are listed as "DISABLED", the current version in this case happened to be a version hidden on page 3.

Comment 3

[Andrew Williamson [:eviljeff]]

this isn't an issue any more as hosted apps only have one version and Rob flattened the review history for the kind of apps this bug was affecting a few months ago.