The default bug view has changed. See this FAQ.

Plugin preview overlay shows click-to-play icon when preview is present

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: yury, Assigned: yury)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 654743 [details] [diff] [review]
adds canActivatePlugin check to reshowClickToPlayNotification

Per bug 776208 comment 61:

(In reply to David Keeler from comment #59)
> Comment on attachment 654628 [details] [diff] [review] [diff] [review]
> Plugin overlay API
> 
> Review of attachment 654628 [details] [diff] [review] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/browser-plugins.js
> @@ +198,5 @@
> >      let cwu = aContentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
> >                              .getInterface(Ci.nsIDOMWindowUtils);
> >      let haveUnplayedPlugins = cwu.plugins.some(function(plugin) {
> >        let objLoadingContent = plugin.QueryInterface(Ci.nsIObjectLoadingContent);
> > +      return (plugin != aPlugin && gPluginHandler.canActivatePlugin(objLoadingContent));
> 
> Looks like we still need a similar check in reshowClickToPlayNotification

Yeah, that might case to show an icon on desktop when preview exists and click-to-play is on. 

> and _removeClickToPlayOverlays.

Not really necessary -- the preview does not use mainBox (it's hidden in this mode).
(Assignee)

Updated

5 years ago
Attachment #654743 - Attachment is patch: true
Attachment #654743 - Flags: review?(dkeeler)
(Assignee)

Updated

5 years ago
Depends on: 776208
Comment on attachment 654743 [details] [diff] [review]
adds canActivatePlugin check to reshowClickToPlayNotification

Review of attachment 654743 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'm sure you could just add this in to the patch you're getting ready to land in bug 776208 and carry over the r+s. I can't r+, so I'll just mark this feedback+.
Attachment #654743 - Flags: review?(dkeeler) → feedback+
Attachment #654743 - Flags: review+
(Assignee)

Comment 2

5 years ago
Created attachment 654805 [details] [diff] [review]
patch for checkin
Attachment #654743 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=5c8281cb3918
Assignee: nobody → async.processingjs
Status: NEW → ASSIGNED
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Green on Try. Sorry for the obscenely long delay.
https://tbpl.mozilla.org/?tree=Try&rev=5c8281cb3918

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3c861bd1e2f
Flags: in-testsuite-
Sorry, I had to back this out because it depends on bug 776208 which was backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7058cad952ca
(Assignee)

Comment 6

5 years ago
The patch added to/combined with the bug 776208 Plugin overlay API patch
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.