Created attachment 654743 [details] [diff] [review] adds canActivatePlugin check to reshowClickToPlayNotification Per bug 776208 comment 61: (In reply to David Keeler from comment #59) > Comment on attachment 654628 [details] [diff] [review] [diff] [review] > Plugin overlay API > > Review of attachment 654628 [details] [diff] [review] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/base/content/browser-plugins.js > @@ +198,5 @@ > > let cwu = aContentWindow.QueryInterface(Ci.nsIInterfaceRequestor) > > .getInterface(Ci.nsIDOMWindowUtils); > > let haveUnplayedPlugins = cwu.plugins.some(function(plugin) { > > let objLoadingContent = plugin.QueryInterface(Ci.nsIObjectLoadingContent); > > + return (plugin != aPlugin && gPluginHandler.canActivatePlugin(objLoadingContent)); > > Looks like we still need a similar check in reshowClickToPlayNotification Yeah, that might case to show an icon on desktop when preview exists and click-to-play is on. > and _removeClickToPlayOverlays. Not really necessary -- the preview does not use mainBox (it's hidden in this mode).
Comment on attachment 654743 [details] [diff] [review] adds canActivatePlugin check to reshowClickToPlayNotification Review of attachment 654743 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. I'm sure you could just add this in to the patch you're getting ready to land in bug 776208 and carry over the r+s. I can't r+, so I'll just mark this feedback+.
Created attachment 654805 [details] [diff] [review] patch for checkin
https://tbpl.mozilla.org/?tree=Try&rev=5c8281cb3918
Green on Try. Sorry for the obscenely long delay. https://tbpl.mozilla.org/?tree=Try&rev=5c8281cb3918 https://hg.mozilla.org/integration/mozilla-inbound/rev/b3c861bd1e2f
Sorry, I had to back this out because it depends on bug 776208 which was backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/7058cad952ca
The patch added to/combined with the bug 776208 Plugin overlay API patch
or
