Closed Bug 785229 Opened 8 years ago Closed 8 years ago

Nightly repacks failing when building libmar

Categories

(SeaMonkey :: Release Engineering, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: ewong)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

I'm assigning ewong, since I won't have time to work on this for at least a week, but is a simple fix.

We'll need a SeaMonkey port of this fix.

+++ This bug was initially created as a clone of Bug #785066 +++

Firefox linux/mac l10n builds fail to build ( http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1345721144.1345721180.14359.gz ) with errors like:

/usr/bin/gcc-4.2 -o host_mar_create.o -c -DXP_UNIX -DXP_MACOSX -DNO_X11 -O3   -I../../../modules/libmar/src -I. -I../../../dist/include  -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nspr -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nss     -I/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/dist/include/nspr /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c
In file included from /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12:
/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:12:37: error: mozilla/StandardInteger.h: No such file or directory
In file included from /builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_create.c:12:
/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:16: error: 'uint32_t' undeclared here (not in a function)
/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:17: error: 'uint64_t' undeclared here (not in a function)
/builds/slave/m-cen-osx64-l10n-ntly/build/mozilla-central/modules/libmar/src/mar_private.h:43: error: 'uint32_t' undeclared here (not in a function)
make[2]: *** [host_mar_create.o] Error 1
make[1]: *** [libs] Error 2
make: *** [default] Error 2


Sounds like fallout due Bug 579517
Status: NEW → ASSIGNED
Attached patch Changed nspr to base. (v1) (obsolete) — Splinter Review
Attachment #654893 - Flags: review?(bugspam.Callek)
Comment on attachment 654893 [details] [diff] [review]
Changed nspr to base. (v1)

The dependant MoCo bug changed more, this looks good but lets adjust to match before we land. (You can have r+=me in advance for that, but explicitly marking r- on this patch as well for the mere fact that I don't want this one to land as-is)
Attachment #654893 - Flags: review?(bugspam.Callek)
Attachment #654893 - Flags: review-
Attachment #654893 - Flags: review+
Attachment #654893 - Attachment is obsolete: true
Attachment #655309 - Flags: review?(bugspam.Callek)
Attachment #655309 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
Pushed to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/0cbf392e17b0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.