785234 - IonMonkey: Support IP => PC translation for profiling

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[u443197]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_0) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.14 Safari/537.4

Comment 1

[u443197]

This was done in part 4 of bug 778979 for JaegerMonkey

Comment 2

[Nicolas B. Pierron [:nbp]]

For IonMonkey, you can have a look at  bug 728045 attachment 601889 [details] [diff] [review], which was made to solve GetPCScript issues by mapping IP -> PC & script in an Ion Script.

The memory impact of markSafepoint location was not big enough to justify using this CompactMap class, but profiling will register one IP -> PC per instruction, which is likely to consume way more memory.

Comment 3

[u443197]

Attachment: patch

Rough idea, will work on more tomorrow and actually comment things so there's hope of someone else being able to read this.

Comment 4

[u443197]

Attachment: Part 1 - Remove trackedPc and use MIR nodes to track it instead

Comment 5

[u443197]

Attachment: Part 2 - Provide an IP => PC mapping for IonMonkey

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 655235 [details] [diff] [review]
Part 1 - Remove trackedPc and use MIR nodes to track it instead

Sorry for the late review, and thanks for doing this! This approach looks a lot cleaner.

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: Part 1 - Remove trackedPc and use MIR nodes to track it instead (rebased)

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Jan, this might still be relevant, it's a nice clean-up to MIR and makes profiler support a lot more flexible.

Comment 9

[Markus Stange [:mstange]]

Kannan, are the patches here still relevant or did your work obsolete them completely?

Comment 10

[Kannan Vijayan [:djvj]]

Obsolete