785280 - Support Metro-style menupopup elements

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jonathan Wilde [:jwilde]]

Menupopups should be anchored near their launching element, just like menupopups do on desktop fx.  Unlike desktop fx, these need to be rendered in chrome scripts without extra windows.

Comment 1

[Jonathan Wilde [:jwilde]]

http://hg.mozilla.org/projects/elm/rev/a77cce66f0da

Comment 2

[Brian R. Bondy [:bbondy]]

Did you add support for an XUL menupopups here? I just looked quick but it just looks like some cleanup of the context menu ui helper code.  Just wondering for future use :)

Comment 3

[Jonathan Wilde [:jwilde]]

It adds support for menupopups when attached to menulists.  I'll also go add XBL so it works for button[type=menu] elements, too.  :D

Comment 4

[Jonathan Wilde [:jwilde]]

It also:
- adds shiny animations
- tweaks the border width (it was correct already, but needed to be !important)
- tidies up platform.css
- restructures the menu code and adds support for menupopup

That last point is really useful because there were three identical systems for doing that (one for context menu, one for menupopup, one for in-content select) with separate codebases.

This new version still keeps a separate wrapper for each of those cases (since there's going to be different ways to autofill the menu), but centralizes the code for opening and closing the menu.  Opening and closing menus is actually a little more complex than it used to be because of the opening/closing animations.

Comment 5

[Brian R. Bondy [:bbondy]]

Sounds great! :)

Comment 6

[Jonathan Wilde [:jwilde]]

If you have a menulist in a scroll frame, boxObject doesn't take scroll position into account.  Switching over to using element.getBoundingClientRect so that the menulist is displayed in the correct initial spot.

http://hg.mozilla.org/projects/elm/rev/9a814608c96b

Comment 7

[Jonathan Wilde [:jwilde]]

Note: in regards to comment 3, I didn't have time to implement that during the course of my internship, so currently this only supports menupopup elements in the context of menulist elements.

Comment 8

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.