785305 - "Assertion failure: pn->isArity(PN_NAME) || pn->isArity(PN_NULLARY),"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Reflect.parse("\
  function l(x = (function() {})) {\
	function x() {}\
  }\
")

asserts js debug shell on m-c changeset 29ca472bf2d2 without any CLI arguments at Assertion failure: pn->isArity(PN_NAME) || pn->isArity(PN_NULLARY),

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   95646:70acf458a32d
user:        Benjamin Peterson
date:        Sat Jun 02 20:16:24 2012 +0200
summary:     Bug 759498: fix defaults when arguments are bound as functions, r=jorendorff

Comment 1

[:Benjamin Peterson]

Attachment: account for strange parse node structure

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 657509 [details] [diff] [review]
account for strange parse node structure

Review of attachment 657509 [details] [diff] [review]:
-----------------------------------------------------------------

Can we assert there that arg is either PNK_NAME or PNK_ASSIGN? The assertion would document what the heck arg->pn_left is supposed to mean, which is otherwise unobvious.

If not an assertion, then a comment. r=me with that.

Comment 3

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fefdc97754e1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fefdc97754e1

Comment 5

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929