Last Comment Bug 785335 - Changing an elements tagName collapses the tree node with no way to expand the tree node
: Changing an elements tagName collapses the tree node with no way to expand th...
Status: RESOLVED FIXED
[fixed-in-fx-team]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: 17 Branch
: All All
: P1 normal (vote)
: Firefox 17
Assigned To: Dave Camp (:dcamp)
:
Mentors:
Depends on:
Blocks: 777085 785628
  Show dependency treegraph
 
Reported: 2012-08-24 02:09 PDT by (Away 6/25-7/4) Jared Wein [:jaws] (reviews and needinfo disabled until back)
Modified: 2012-08-25 17:07 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (7.85 KB, patch)
2012-08-24 15:07 PDT, Dave Camp (:dcamp)
no flags Details | Diff | Review
v2 (7.97 KB, patch)
2012-08-25 08:45 PDT, Dave Camp (:dcamp)
jwalker: review+
paul: review+
Details | Diff | Review

Description (Away 6/25-7/4) Jared Wein [:jaws] (reviews and needinfo disabled until back) 2012-08-24 02:09:19 PDT
Using the build from http://hg.mozilla.org/integration/fx-team/rev/844da7b047d2

STR:
1) Go to about:home
2) Open the Inspector
3) Double-click on the tagName for <body>
4) Change the tag name to <div>

Expected:
The markup for the page is still visible

Actual:
The tree node for the body collapses and I can't find a way to expand the markup tree.
Comment 1 Dave Camp (:dcamp) 2012-08-24 15:07:27 PDT
Created attachment 655179 [details] [diff] [review]
v1

This patch propagates the selection and expandedness to the new container after a tag rename.  Also fixes a console warning when iframes are loaded when not visible in the markup panel.
Comment 2 Dave Camp (:dcamp) 2012-08-25 08:45:06 PDT
Created attachment 655322 [details] [diff] [review]
v2

This version uses navigate() instead of selectNode() so that the highlighter will point at the new version of the element too.
Comment 4 Dave Camp (:dcamp) 2012-08-25 17:07:32 PDT
https://hg.mozilla.org/mozilla-central/rev/328402a45248

Note You need to log in before you can comment on or make changes to this bug.