Changing an elements tagName collapses the tree node with no way to expand the tree node

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Inspector
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: dcamp)

Tracking

17 Branch
Firefox 17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

v2
7.97 KB, patch
jwalker
: review+
paul
: review+
Details | Diff | Splinter Review
Using the build from http://hg.mozilla.org/integration/fx-team/rev/844da7b047d2

STR:
1) Go to about:home
2) Open the Inspector
3) Double-click on the tagName for <body>
4) Change the tag name to <div>

Expected:
The markup for the page is still visible

Actual:
The tree node for the body collapses and I can't find a way to expand the markup tree.
(Assignee)

Updated

5 years ago
Assignee: nobody → dcamp
Priority: -- → P1

Updated

5 years ago
Depends on: 785380

Updated

5 years ago
No longer depends on: 785380
(Assignee)

Comment 1

5 years ago
Created attachment 655179 [details] [diff] [review]
v1

This patch propagates the selection and expandedness to the new container after a tag rename.  Also fixes a console warning when iframes are loaded when not visible in the markup panel.
Attachment #655179 - Flags: review?(jwalker)
(Assignee)

Comment 2

5 years ago
Created attachment 655322 [details] [diff] [review]
v2

This version uses navigate() instead of selectNode() so that the highlighter will point at the new version of the element too.
Attachment #655179 - Attachment is obsolete: true
Attachment #655179 - Flags: review?(jwalker)
Attachment #655322 - Flags: review?(jwalker)
(Assignee)

Updated

5 years ago
Attachment #655322 - Flags: review?(paul)
(Assignee)

Updated

5 years ago
Blocks: 785628

Updated

5 years ago
Attachment #655322 - Flags: review?(paul) → review+
Attachment #655322 - Flags: review?(jwalker) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/328402a45248
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/328402a45248
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.