Closed Bug 785335 Opened 8 years ago Closed 8 years ago

Changing an elements tagName collapses the tree node with no way to expand the tree node

Categories

(DevTools :: Inspector, defect, P1)

17 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: jaws, Assigned: dcamp)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

Using the build from http://hg.mozilla.org/integration/fx-team/rev/844da7b047d2

STR:
1) Go to about:home
2) Open the Inspector
3) Double-click on the tagName for <body>
4) Change the tag name to <div>

Expected:
The markup for the page is still visible

Actual:
The tree node for the body collapses and I can't find a way to expand the markup tree.
Assignee: nobody → dcamp
Priority: -- → P1
Depends on: 785380
No longer depends on: 785380
Attached patch v1 (obsolete) — Splinter Review
This patch propagates the selection and expandedness to the new container after a tag rename.  Also fixes a console warning when iframes are loaded when not visible in the markup panel.
Attachment #655179 - Flags: review?(jwalker)
Attached patch v2Splinter Review
This version uses navigate() instead of selectNode() so that the highlighter will point at the new version of the element too.
Attachment #655179 - Attachment is obsolete: true
Attachment #655179 - Flags: review?(jwalker)
Attachment #655322 - Flags: review?(jwalker)
Attachment #655322 - Flags: review?(paul)
Blocks: 785628
Attachment #655322 - Flags: review?(paul) → review+
Attachment #655322 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/mozilla-central/rev/328402a45248
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.