785343 - Text in select/option elements affect the scoring

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P2)

Description

[Lucas Rocha (:lucasr)]

Pages like http://money.cnn.com/gallery/real_estate/2012/08/20/best-places-top-earning-towns.moneymag?hpt=hp_c2 and http://edition.cnn.com/WORLD/ have select elements with tons of options in them. The DIV containing this form is winning as best candidate because of this. We should penalize or ignore form elements when counting how content-ey an element is.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Don't convert DIV to P when it only contains a SELECT node

Comment 2

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/66cd9a420997

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 654983 [details] [diff] [review]
Don't convert DIV to P when it only contains a SELECT node

[Approval Request Comment]
User impact if declined: Some websites with SELECT elements with tons of options might affect readability parsing leading to reader showing just a bunch SELECT elements in reader mode for websites like cnn.com.
Testing completed (on m-c, etc.): Local testing on mentioned websites and others, no regressions found.
Risk to taking this patch (and alternatives if risky): Low as it only affect a very specific type of content (DIVs with only a SELECT item inside).
String or UUID changes made by this patch: None.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66cd9a420997

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 654983 [details] [diff] [review]
Don't convert DIV to P when it only contains a SELECT node

[Triage Comment]
Approving for Beta 17 given this is a low risk fix for a regression in a new feature.

Comment 6

[Lucas Rocha (:lucasr)]

Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/0bdc3f473627

Comment 7

[Cristian Nicolae (:xti)]

This issue seems to be fixed after I loaded the pages from comment #0 on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4