785453 - Change Mac OS X "remember password" panel key icon for higher contrast

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot

After check in bug 771284, doorhanger arrow panel of "save password" looks changes not clear. Key icon's color mix with background color. This is bad from visibility.
It need to update the key icon at some future date.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Maybe this key can be used? http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/passwordmgr/key-64.png

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Chris, can you take this and get it fixed before the merge on Monday?

Comment 3

[Chris Lee (:cleer)]

Attachment: Patch v1

Changing the icon to the equivalent Windows icon (posted by jaws). In the future, might be worth modifying the icon to be more consistent with the OS X icon style and yet preserve contrast.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 655220 [details] [diff] [review]
Patch v1

r+ from me, let's wait on stephen's input before landing though.

Comment 5

[Stephen Horlander [:shorlander]]

Comment on attachment 655220 [details] [diff] [review]
Patch v1

Review of attachment 655220 [details] [diff] [review]:
-----------------------------------------------------------------

The key icon can probably use more contrast now, but we shouldn't replace it with an icon designed for another platform.

Comment 6

[Tim Nguyen :ntim]

Matt, can this now be closed ?

Comment 7

[Matthew N. [:MattN]]

Looks like it.