Last Comment Bug 785459 - Enable the WebIDL parser to be used stand-alone for syntax checking
: Enable the WebIDL parser to be used stand-alone for syntax checking
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 11:52 PDT by :Ehsan Akhgari
Modified: 2012-08-24 20:00 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.74 KB, patch)
2012-08-24 11:53 PDT, :Ehsan Akhgari
khuey: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-08-24 11:52:37 PDT

    
Comment 1 :Ehsan Akhgari 2012-08-24 11:53:22 PDT
Created attachment 655080 [details] [diff] [review]
Patch (v1)
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-08-24 12:19:50 PDT
Comment on attachment 655080 [details] [diff] [review]
Patch (v1)

Review of attachment 655080 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +3679,5 @@
> +            if options.verbose_errors:
> +                traceback.print_exc()
> +            else:
> +                print e
> +    parser.finish()

parser.finish() can throw too, say if you referenced an interface somewhere that was never defined.
Comment 4 :Ehsan Akhgari 2012-08-24 13:48:40 PDT
Pushed a follow-up for python 2.5 compatibility:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f56f3d3f2c12

Note You need to log in before you can comment on or make changes to this bug.